Support Ledger clear signing (#1603)

Author: franciszekjob

.github/workflows/checks.yml

@@ -2,9 +2,9 @@ name: Checks
 
 env:
   CAIRO_LANG_VERSION: "0.13.1"
-  DEVNET_SHA: fc5a2753a2eedcc27eed7a4fae3ecac08c2ca1b4
-  LEDGER_APP_SHA: db93a5e33d00bd44752fdc8c07aefcffa08d91c3
-  LEDGER_APP_DEV_TOOLS_SHA: a037d42181f4bed9694246256e2c9e2a899e775c302a9c6482c81f87c28e1432
+  DEVNET_SHA: 26292d1f92807090776b470f43b321f150f55ffd # v0.4.1
+  LEDGER_APP_SHA: 768a7b47b0da681b28112342edd76e2c9b292c4e # v2.3.1
+  LEDGER_APP_DEV_TOOLS_SHA: a845b2ab0b5dd824133f73858f6f373edea85ec1bd828245bf50ce9700f33bcb # v4.5.0
 
 on:
   push:
@@ -200,6 +200,7 @@ jobs:
           run: |
             cd /apps/app-starknet
             git checkout ${{ env.LEDGER_APP_SHA }}
+            cd starknet
             cargo clean
             cargo ledger build nanox
 
@@ -219,6 +220,9 @@ jobs:
       - name: Wait for Speculos to start
         run: sleep 5
 
+      - name: Allow blind signing
+        run: ./starknet_py/tests/unit/signer/allow_ledger_blind_signing.sh
+
       - name: Update automation rules
         working-directory: starknet_py/tests/unit/signer
         run: |

docs/api/signer.rst

@@ -47,3 +47,11 @@ To use LedgerSigner, you need to install starknetpy with `ledger` extra like thi
 .. autoclass:: LedgerSigner
     :members:
     :member-order: groupwise
+
+-----------------
+LedgerSigningMode
+-----------------
+
+.. autoclass:: LedgerSigningMode
+    :members:
+    :member-order: groupwise

docs/guide/signing.rst

@@ -15,7 +15,7 @@ signing algorithm, it is possible to create ``Account`` with custom
 Signing with Ledger
 -------------------
 :ref:`LedgerSigner` allows you to sign transactions using a Ledger device. The device must be unlocked and Starknet app needs to be open.
-Currently used version of Starknet app is ``1.1.1`` and only blind-signing is possible. Clear-signing will be available in the near future.
+Currently used version of `Starknet app <https://github.com/LedgerHQ/app-starknet>`_ is ``2.3.1``.
 
 .. codesnippet:: ../../starknet_py/tests/unit/signer/test_ledger_signer.py
     :language: python

docs/migration_guide.rst

@@ -2,10 +2,15 @@ Migration guide
 ===============
 
 **********************
-0.26.3 Migration guide
+0.27.0 Migration guide
 **********************
 
-0.26.3 Bugfixes
+.. py:currentmodule:: starknet_py.net.signer.ledger_signer
+
+1. Support for clear signing with :class:`LedgerSigner` has been added. It's now the default signing mode (see :class:`LedgerSigningMode`).
+2. ``derivation_path_str`` param has been removed from :class:`LedgerSigner` constructor, while ``account_id``, ``application_name`` and ``signing_mode`` params have been added.
+
+0.27.0 Bugfixes
 ---------------
 
 1. ABI parser supports now fixed size arrays.

poetry.lock

@@ -32,7 +32,6 @@ docs = [
 ]
 ledger = [
     "ledgerwallet>=0.5.0,<1.0.0",
-    "bip-utils>=2.9.3,<3.0.0",
 ]
 
 [project.urls]

pyproject.toml

@@ -39,14 +39,6 @@
 
 ROOT_PATH = Path(__file__).parent
 
-# Ledger constants
-STARKNET_CLA = 0x5A
-EIP_2645_PURPOSE = 0x80000A55
-EIP_2645_PATH_LENGTH = 6
-PUBLIC_KEY_RESPONSE_LENGTH = 65
-SIGNATURE_RESPONSE_LENGTH = 65
-VERSION_RESPONSE_LENGTH = 3
-
 # Result of `encode_shortstring("ANY_CALLER")`
 ANY_CALLER = 0x414E595F43414C4C4552
 
@@ -58,3 +50,7 @@ class OutsideExecutionInterfaceID(IntEnum):
 
 
 EXPECTED_RPC_VERSION = "0.8.1"
+
+ARGENT_V040_CLASS_HASH = (
+    0x036078334509B514626504EDC9FB252328D1A240E4E948BEF8D0C08DFF45927F
+)