failed test case

Author: baitcode

pyproject.toml

@@ -56,15 +56,16 @@ setuptools = "^70.3.0"
 test = [
     "clean_coverage",
     "test_ci_v1 --disable-warnings -qq",
-    "test_ci_v2 --disable-warnings -qq",
-    "test_ci_on_networks --disable-warnings -qq",
-    "test_ci_docs_v1 --disable-warnings -qq",
-    "test_ci_docs_v2 --disable-warnings -qq",
-    "test_report --skip-covered"
+    # "test_ci_v2 --disable-warnings -qq",
+    # "test_ci_on_networks --disable-warnings -qq",
+    # "test_ci_docs_v1 --disable-warnings -qq",
+    # "test_ci_docs_v2 --disable-warnings -qq",
+    # "test_report --skip-covered"
 ]
 
 test_ci = ["test_ci_v1", "test_ci_v2"]
-test_ci_v1 = "coverage run -a -m pytest --contract_dir=v1 starknet_py --ignore=starknet_py/tests/e2e/docs --ignore=starknet_py/tests/e2e/tests_on_networks"
+test_ci_v1 = "coverage run -a -m pytest --contract_dir=v1 starknet_py --ignore=starknet_py/tests/e2e/docs --ignore=starknet_py/tests/e2e/tests_on_networks starknet_py/tests/e2e/account"
+# test_ci_v1 = "coverage run -a -m pytest --contract_dir=v1 starknet_py --ignore=starknet_py/tests/e2e/docs --ignore=starknet_py/tests/e2e/tests_on_networks"
 test_ci_v2 = "coverage run -a -m pytest --contract_dir=v2 starknet_py --ignore=starknet_py/tests/e2e/docs --ignore=starknet_py/tests/e2e/tests_on_networks"
 
 test_ci_on_networks = "coverage run -a -m pytest --contract_dir=v2 starknet_py/tests/e2e/tests_on_networks"

starknet_py/net/account/base_account.py

@@ -62,7 +62,7 @@ async def sign_outside_execution_call(
             supports and use the highest one and populate the value.
         """
 
-class BaseAccount(ABC):
+class BaseAccount(SNIP9SupportMixin, ABC):
     """
     Base class for all account implementations.
 

starknet_py/tests/e2e/account/account_test.py

@@ -41,6 +41,9 @@
     MAX_RESOURCE_BOUNDS,
     MAX_RESOURCE_BOUNDS_L1,
 )
+from starknet_py.transaction_errors import (
+    TransactionRevertedError,
+)
 
 
 @pytest.mark.run_on_devnet
@@ -857,7 +860,7 @@ async def test_account_execute_v3(account, deployed_balance_contract):
     assert initial_balance + 100 == balance_after_increase
 
 @pytest.mark.asyncio
-async def test_account_outside_execution(
+async def test_account_outside_execution_any_caller(
     client,
     argent_account_class_hash,
     deployed_balance_contract,
@@ -890,7 +893,7 @@ async def test_account_outside_execution(
         calldata=[100],
     )
 
-    call = await account.sign_execute_outside_call(
+    call = await account.sign_outside_execution_call(
         calls=[
             increase_balance_call,
             increase_balance_call,
@@ -905,3 +908,58 @@ async def test_account_outside_execution(
 
     tx = await account.execute_v1(calls=[call], max_fee=MAX_FEE)
     await account.client.wait_for_tx(tx.transaction_hash)
+
+
+@pytest.mark.asyncio
+async def test_account_outside_execution_for_invalid_caller(
+    client,
+    argent_account_class_hash,
+    deployed_balance_contract,
+    deploy_account_details_factory,
+):
+    address, key_pair, salt, class_hash = await deploy_account_details_factory.get(
+        class_hash=argent_account_class_hash, argent_calldata=True
+    )
+
+    deploy_result = await Account.deploy_account_v1(
+        address=address,
+        class_hash=class_hash,
+        salt=salt,
+        key_pair=key_pair,
+        client=client,
+        constructor_calldata=[key_pair.public_key, 0],
+        max_fee=MAX_FEE,
+    )
+    await deploy_result.wait_for_acceptance()
+    account = deploy_result.account
+
+    assert any([
+        await account.supports_interface(SNIP9InterfaceVersion.V1),
+        await account.supports_interface(SNIP9InterfaceVersion.V2),
+    ])
+
+    increase_balance_call = Call(
+        to_addr=deployed_balance_contract.address,
+        selector=get_selector_from_name("increase_balance"),
+        calldata=[100],
+    )
+
+    call = await account.sign_outside_execution_call(
+        calls=[
+            increase_balance_call,
+            increase_balance_call,
+            increase_balance_call,
+        ],
+        execution_time_bounds=ExecutionTimeBounds(
+            execute_after=datetime.datetime.now() - datetime.timedelta(hours=1),
+            execute_before=datetime.datetime.now() + datetime.timedelta(hours=1),
+        ),
+        caller=deployed_balance_contract.address,
+    )
+
+    tx = await account.execute_v1(calls=[call], max_fee=MAX_FEE)
+
+    with pytest.raises(TransactionRevertedError) as err:
+        await account.client.wait_for_tx(tx.transaction_hash)
+
+    assert 'argent/invalid-caller' in err.value.message