-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreateMint
instruction
#6
Conversation
@grod220 as per discussion on Zoom, there were a few small changes you wanted to make, then I can review. Just let me know when you're ready with a comment + tag! |
@buffalojoec Ready for your review 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far! Nice work.
I left a bunch of comments, a lot of them small/nits, and I only skimmed the tests for now. I'll look at those closer once we've chatted about the other items!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of great stuff here! Mostly small things, and I agree with all of Joe's points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking close! Mostly small things, then I'm happy to get this in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! But do get an approval from @buffalojoec too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! This is super close, just a few tiny nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for all of the back and forth!
This PR builds out the
CreateMint
instruction enabling the creation of "wrapped" token-2022 tokens from existing spl-token tokens (and vice versa). The intention is to facilitate interoperability between different token standards.Mainly creates two accounts:
Future work to build out remaining wrap & unwrap instructions.