From f02edab02b5d1a2a37e7d3a3b4b9dbb4496410ed Mon Sep 17 00:00:00 2001
From: bm743 <bm743@cornell.edu>
Date: Fri, 7 Feb 2025 11:55:12 -0500
Subject: [PATCH] Only show set display image option to curator role

---
 mason/image/print_images.mas             | 10 +++++-----
 mason/page/detail_page_2_col_section.mas |  8 ++------
 mason/stock/index.mas                    |  2 +-
 3 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/mason/image/print_images.mas b/mason/image/print_images.mas
index 6915bf940c..56d75172b7 100644
--- a/mason/image/print_images.mas
+++ b/mason/image/print_images.mas
@@ -72,12 +72,12 @@ if ($images && !$image_objects) {
 ###print qq{  <script src="jquery.colorbox-min.js"></script> };
 
 if ($image_objects)  { # don't display anything for empty list of images
-  if ($stock_image_flag == '1') { # Only include 'Set as Display Image' column for images of this stock, not for images of related stock table
+  if ($curator && $stock_image_flag == '1') { # Only include 'Set as Display Image' column for images of this stock, not for images of related stock table
     $image_html .= qq|<table class="table table-bordered"><thead><tr><th><button class="btn btn-sm btn-default" id="print_images_multi_image_view">View Selected</button></th><th>Image</th><th>Description</th><th>Type</th><th>Set as Display Image</th></tr></thead><tbody>|;
   } else {
     $image_html .= qq|<table class="table table-bordered"><thead><tr><th><button class="btn btn-sm btn-default" id="print_images_multi_image_view">View Selected</button></th><th>Image</th><th>Description</th><th>Type</th></tr></thead><tbody>|;
   }
-  print "<div>check_curator_role: $stock_image_flag</div>";
+  
   my $i = 0;
   foreach my $image_ob (@$image_objects) {
     $count++;
@@ -104,9 +104,9 @@ if ($image_objects)  { # don't display anything for empty list of images
               . $image_description
                 . "</td><td>"
                 .  $images->[$i]->[1]
-                .  "</td><td>"
-                .  $set_button
-                . "</td></tr>";
+                .  "</td>"
+                .  ($curator == 1 ? "<td>$set_button</td>" : "")
+                . "</tr>";
     if ( $count < 3 ) { $image_html .= $fhtml; }
     else {
       push @more_is, $fhtml;
diff --git a/mason/page/detail_page_2_col_section.mas b/mason/page/detail_page_2_col_section.mas
index 136b40de9f..cde69b6276 100644
--- a/mason/page/detail_page_2_col_section.mas
+++ b/mason/page/detail_page_2_col_section.mas
@@ -322,13 +322,9 @@ $field_headers => ()
 
 % if ($info_section_id eq 'stock_images_section'){
                                 <& /image/compare_images.mas, stock_id => $stock_id &>
-                                <%perl>
-                                if ($curator == 1) {
-                                    $stock_image_flag = '1';
-                                }
-                                </%perl>
+
                                 <&| /page/info_section.mas, title=>"Images of This Stock(" .  scalar(@$image_ids)  . ")", collapsible=>1, collapsed=>0 &>
-                                    <& /image/print_images.mas , stock_id=>$stock_id , images=>$image_ids , dbh=>$dbh, additional_image_button_id=>'stock_images', stock_image_flag=>$stock_image_flag , curator=>$curator &>
+                                    <& /image/print_images.mas , stock_id=>$stock_id , images=>$image_ids , dbh=>$dbh, additional_image_button_id=>'stock_images', stock_image_flag=>'1' , curator=>$curator &>
                                 </&>
 
                                 <&| /page/info_section.mas, title=>"Images of Related Stock(s) (" .  scalar(@$related_image_ids)  . ")", collapsible=>1, collapsed=>0 &>
diff --git a/mason/stock/index.mas b/mason/stock/index.mas
index 6e2994db22..e44f0e27cb 100644
--- a/mason/stock/index.mas
+++ b/mason/stock/index.mas
@@ -392,7 +392,7 @@ function jqueryStuff() {
 
 % }
     
-    <& /page/detail_page_2_col_section.mas, stock_id => $stock_id, info_section_title => "<h4 style='display:inline'>Images $curator</h4>", info_section_subtitle => 'View and add images of this stock and of related stocks.', icon_class => "glyphicon glyphicon-camera", info_section_id => "stock_images_section", image_ids => $image_ids, related_image_ids => $related_image_ids, dbh => $dbh, buttons_html => qq|<a id="add_new_image_button" class="btn btn-sm btn-default" style="margin:3px" href="/image/add?type_id=$stock_id&action=new&type=stock&refering_page=$this_page">Add new image</a><a class="btn btn-sm btn-default" style="margin:3px" id="stock_images_section_compare_images_button">Compare Images</a>| &>
+    <& /page/detail_page_2_col_section.mas, stock_id => $stock_id, info_section_title => "<h4 style='display:inline'>Images</h4>", info_section_subtitle => 'View and add images of this stock and of related stocks.', icon_class => "glyphicon glyphicon-camera", info_section_id => "stock_images_section", image_ids => $image_ids, related_image_ids => $related_image_ids, dbh => $dbh, curator =>$curator, buttons_html => qq|<a id="add_new_image_button" class="btn btn-sm btn-default" style="margin:3px" href="/image/add?type_id=$stock_id&action=new&type=stock&refering_page=$this_page">Add new image</a><a class="btn btn-sm btn-default" style="margin:3px" id="stock_images_section_compare_images_button">Compare Images</a>| &>
 
     <& /page/detail_page_2_col_section.mas, stock_id => $stock_id, info_section_title => "<h4 style='display:inline'>Upload Data Files</h4>", info_section_subtitle => 'Upload any additional files for this Accession.', icon_class => "glyphicon glyphicon-cloud-upload", info_section_id => "stock_upload_files" &>