Skip to content

Commit 665fecf

Browse files
authored
backout APIKey skip_metadata_validation API change (#10188)
1 parent c58a936 commit 665fecf

File tree

8 files changed

+999
-1059
lines changed

8 files changed

+999
-1059
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
changelog:
2+
- type: NON_USER_FACING
3+
issueLink: https://github.com/solo-io/ext-auth-service/issues/762
4+
resolvesIssue: false
5+
description: >-
6+
Revert updating extauth APIKey config to add 'skipMetadataValidation', as we will not be backporting to this version

docs/content/reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto.sk.md

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

install/helm/gloo/crds/enterprise.gloo.solo.io_v1_AuthConfig.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,6 @@ spec:
158158
additionalProperties:
159159
type: string
160160
type: object
161-
skipMetadataValidation:
162-
type: boolean
163161
type: object
164162
basicAuth:
165163
properties:

projects/gloo/api/v1/enterprise/options/extauth/v1/extauth.proto

+1-10
Original file line numberDiff line numberDiff line change
@@ -1023,12 +1023,8 @@ message ApiKeyAuth {
10231023
// to the request.
10241024
bool required = 2;
10251025
}
1026-
1027-
// API key metadata may contain data is is invalid for a header, such as a newline. By default, this data will be validated
1028-
// in the data plane and mitigated in a way that provides a consistent experience for the user and visibility for the operator.
1029-
// This validation comes with a performance cost, and can be disabled by setting this field to `true`.
1030-
bool skip_metadata_validation = 8;
10311026
}
1027+
10321028
message K8sSecretApiKeyStorage {
10331029
// Identify all valid API key secrets that match the provided label selector.<br/>
10341030
// API key secrets must be in one of the watch namespaces for gloo to locate them.
@@ -1852,11 +1848,6 @@ message ExtAuthConfig {
18521848
K8sSecretApiKeyStorage k8s_secret_apikey_storage = 4;
18531849
AerospikeApiKeyStorage aerospike_apikey_storage = 5;
18541850
}
1855-
1856-
// API key metadata may contain data is is invalid for a header, such as a newline. By default, this data will be validated
1857-
// in the data plane and mitigated in a way that provides a consistent experience for the user and visibility for the operator.
1858-
// This validation comes with a performance cost, and can be disabled by setting this field to `true`.
1859-
bool skip_metadata_validation = 6;
18601851
}
18611852

18621853
message OpaAuthConfig {

projects/gloo/pkg/api/v1/enterprise/options/extauth/v1/extauth.pb.clone.go

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

projects/gloo/pkg/api/v1/enterprise/options/extauth/v1/extauth.pb.equal.go

-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)