From c559bed10c19b14e07c876d8b31dbf374bc66843 Mon Sep 17 00:00:00 2001 From: David Jumani Date: Thu, 14 Nov 2024 11:47:18 -0500 Subject: [PATCH] fix failing unit tests --- .github/workflows/pr-unit-tests.yaml | 3 +++ test/kubernetes/testutils/helper/util_test.go | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-unit-tests.yaml b/.github/workflows/pr-unit-tests.yaml index d3b6988e95f..a24c015d06e 100644 --- a/.github/workflows/pr-unit-tests.yaml +++ b/.github/workflows/pr-unit-tests.yaml @@ -6,6 +6,9 @@ name: Unit Tests # # Our historical unit tests are run via CloudBuild # Overtime, it would be valuable to consolidate these approaches +env: + VERSION: '1.0.0-ci1' + GITHUB_TOKEN: ${{ github.token }} on: pull_request: diff --git a/test/kubernetes/testutils/helper/util_test.go b/test/kubernetes/testutils/helper/util_test.go index 91a8a4ac272..ed8c891639b 100644 --- a/test/kubernetes/testutils/helper/util_test.go +++ b/test/kubernetes/testutils/helper/util_test.go @@ -23,8 +23,8 @@ func TestReturnsLatestPatchForMinor(t *testing.T) { ctx := context.Background() // this is fine because this is a public repo client := githubutils.GetClientWithOrWithoutToken(ctx) - minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 8) + minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 9) require.NoError(t, err) - assert.Equal(t, "v1.8.37", minor.String()) + assert.Equal(t, "v1.9.30", minor.String()) }