Skip to content

Commit d402691

Browse files
committed
Couple of items from the PR feedback
1 parent a83c625 commit d402691

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

pkg/utils/api_conversion/trace_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ var _ = Describe("Trace utils", func() {
7171
TargetSpecifier: &envoy_config_core_v3.GrpcService_EnvoyGrpc_{
7272
EnvoyGrpc: &envoy_config_core_v3.GrpcService_EnvoyGrpc{
7373
ClusterName: clusterName,
74-
Authority: "authority",
74+
Authority: authority,
7575
},
7676
},
7777
},

projects/gloo/api/external/envoy/config/trace/v3/opentelemetry.proto

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ message OpenTelemetryConfig {
3737
// listener + the namespace of the Gateway object
3838
string service_name = 3;
3939

40+
// Optional. Current only gRPC is supported, but are intentionally using a oneof
41+
// to allow for future support of HTTP. This structure matches Envoy's.
4042
oneof service_type {
41-
// Optional, if set the communication to the collector will be over gRPC.
43+
// Optional gRPC transport options
4244
GrpcService grpc_service = 4;
4345
}
4446
}

0 commit comments

Comments
 (0)