Show validation index error

Author: leandrogehlen

CHANGELOG.md

@@ -1,6 +1,11 @@
 Yii LinkMany Change Log
 =======================
 
+1.0.2 Under development
+-----------------------
+
+- Show validation index error
+
 1.0.1 Jan 17, 2022
 ------------------
 

src/LinkManyBehavior.php

@@ -117,29 +117,25 @@ public function afterSave()
     public function afterValidate()
     {
         foreach ($this->relations as $definition) {
-            $name = $definition->name;
+            $relationName = $definition->name;
 
             if (!$definition->validate) {
                 continue;
             }
 
-            $errors = [];
-            $models = ArrayHelper::getValue($this->_inserteds, $name, []);
-            $updateds = ArrayHelper::getValue($this->_updateds, $name, []);
+            $models = ArrayHelper::getValue($this->_inserteds, $relationName, []);
+            $updateds = ArrayHelper::getValue($this->_updateds, $relationName, []);
 
             foreach($updateds as $model) {
                 $models[] = $model;
             }
 
-            foreach ($models as $model) {
+            foreach ($models as $i => $model) {
                 if (!$model->validate()) {
-                    $errors[] = $model->getErrors();
+                    $attribute = $relationName . "[$i]";
+                    $this->addError($model, $attribute);
                 }
             }
-
-            foreach ($errors as $error) {
-                $this->owner->addError($name, $error);
-            }
         }
     }
 
@@ -387,4 +383,19 @@ private function findDefinition($name)
         }
         return null;
     }
+
+    /**
+     * Attach errors to owner relational attributes
+     * @param \yii\db\ActiveRecord $model
+     * @param string $relationName
+     * @return void
+     */
+    private function addError($model, $relationName)
+    {
+        foreach ($model->getErrors() as $attributeErrors) {
+            foreach ($attributeErrors as $error) {
+                $this->owner->addError($relationName, $error);
+            }
+        }
+    }
 }

tests/LinkManyBehaviorTest.php

@@ -230,6 +230,35 @@ public function testValidate()
         $this->assertCount(2, $errors['comments']);
     }
 
+    public function testValidateErrorIndex()
+    {
+        $post = Post::findOne(1);
+        $post->fill([
+            'comments' => [
+                [
+                    'subject' => 'Valid subject',
+                    'content' => 'Valid content',
+                ],[
+                    'subject' => 'Valid subject',
+                    'content' => 6789
+                ],[
+                    'subject' => 1234
+                ],
+            ]
+        ],'');
+
+        $post->validate();
+
+        $this->assertEquals([
+            'comments[1]' => [
+                'Content must be a string.'
+            ],
+            'comments[2]' => [
+                'Subject must be a string.',
+                'Content cannot be blank.'
+            ]
+        ], $post->getErrors());
+    }
 
     public function testSetRelation()
     {