Skip to content

Commit 29776ce

Browse files
committed
Revise test_xcvrd.py to enhance the test code coverage.
1 parent 516fec8 commit 29776ce

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

sonic-xcvrd/tests/test_xcvrd.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2046,6 +2046,7 @@ def test_CmisManagerTask_task_worker(self, mock_chassis, mock_get_status_tbl):
20462046
mock_xcvr_api.get_module_type_abbreviation = MagicMock(return_value='QSFP-DD')
20472047
mock_xcvr_api.get_datapath_init_duration = MagicMock(return_value=60000.0)
20482048
mock_xcvr_api.get_module_pwr_up_duration = MagicMock(return_value=70000.0)
2049+
mock_xcvr_api.get_module_pwr_down_duration = MagicMock(return_value=70000.0)
20492050
mock_xcvr_api.get_datapath_deinit_duration = MagicMock(return_value=600000.0)
20502051
mock_xcvr_api.get_cmis_rev = MagicMock(return_value='5.0')
20512052
mock_xcvr_api.get_supported_freq_config = MagicMock(return_value=(0xA0,0,0,191300,196100))
@@ -2077,7 +2078,6 @@ def test_CmisManagerTask_task_worker(self, mock_chassis, mock_get_status_tbl):
20772078
'media_lane_assignment_options': 15
20782079
}
20792080
})
2080-
mock_xcvr_api.get_module_state = MagicMock(return_value='ModuleReady')
20812081
mock_xcvr_api.get_config_datapath_hostlane_status = MagicMock(return_value={
20822082
'ConfigStatusLane1': 'ConfigSuccess',
20832083
'ConfigStatusLane2': 'ConfigSuccess',
@@ -2228,17 +2228,21 @@ def test_CmisManagerTask_task_worker(self, mock_chassis, mock_get_status_tbl):
22282228
# Case 1: Module Inserted --> DP_DEINIT
22292229
task.is_appl_reconfigure_required = MagicMock(return_value=True)
22302230
mock_xcvr_api.decommission_all_datapaths = MagicMock(return_value=True)
2231+
task.need_lp_mode_for_dpdeinit = MagicMock(return_value=True)
22312232
task.task_stopping_event.is_set = MagicMock(side_effect=[False, False, True])
22322233
task.task_worker()
22332234
assert get_cmis_state_from_state_db('Ethernet0', task.xcvr_table_helper.get_status_tbl(task.port_mapping.get_asic_id_for_logical_port('Ethernet0'))) == CMIS_STATE_DP_DEINIT
2235+
assert mock_xcvr_api.set_lpmode.call_count == 1
2236+
mock_xcvr_api.get_module_state = MagicMock(return_value='ModuleLowPwr')
22342237
task.task_stopping_event.is_set = MagicMock(side_effect=[False, False, True])
22352238
task.task_worker()
22362239
assert mock_xcvr_api.set_datapath_deinit.call_count == 1
22372240
assert mock_xcvr_api.tx_disable_channel.call_count == 1
2238-
assert mock_xcvr_api.set_lpmode.call_count == 1
2241+
assert mock_xcvr_api.set_lpmode.call_count == 2
22392242
assert get_cmis_state_from_state_db('Ethernet0', task.xcvr_table_helper.get_status_tbl(task.port_mapping.get_asic_id_for_logical_port('Ethernet0'))) == CMIS_STATE_AP_CONF
22402243

22412244
# Case 2: DP_DEINIT --> AP Configured
2245+
mock_xcvr_api.get_module_state = MagicMock(return_value='ModuleReady')
22422246
task.task_stopping_event.is_set = MagicMock(side_effect=[False, False, True])
22432247
task.task_worker()
22442248
assert mock_xcvr_api.set_application.call_count == 1

0 commit comments

Comments
 (0)