Refactor method result creation

jonathan-r-thorpe · jonathan-r-thorpe · commit f0016404baaa · 2024-04-26T14:58:05.000+01:00
diff --git a/Development/nmos/configuration_api.cpp b/Development/nmos/configuration_api.cpp
@@ -504,12 +504,9 @@ namespace nmos
                 }
                 else
                 {
-                    web::json::value response = web::json::value_of({
-                        { nmos::fields::nc::status, nmos::fields::nc::is_deprecated(property_descriptor) ? nmos::nc_method_status::property_deprecated : nmos::nc_method_status::ok },
-                        { nmos::fields::nc::value, nc_object.at(nmos::fields::nc::name(property_descriptor)) }
-                        });
+                    web::json::value method_result = details::make_nc_method_result({ nmos::fields::nc::is_deprecated(property_descriptor) ? nmos::nc_method_status::property_deprecated : nmos::nc_method_status::ok }, nc_object.at(nmos::fields::nc::name(property_descriptor)));
 
-                    set_reply(res, status_codes::OK, response);
+                    set_reply(res, status_codes::OK, method_result);
                 }
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -504,12 +504,9 @@ namespace nmos`
`504`	`504`	`}`
`505`	`505`	`else`
`506`	`506`	`{`
`507`		`- web::json::value response = web::json::value_of({`
`508`		`- { nmos::fields::nc::status, nmos::fields::nc::is_deprecated(property_descriptor) ? nmos::nc_method_status::property_deprecated : nmos::nc_method_status::ok },`
`509`		`- { nmos::fields::nc::value, nc_object.at(nmos::fields::nc::name(property_descriptor)) }`
`510`		`- });`
	`507`	`+ web::json::value method_result = details::make_nc_method_result({ nmos::fields::nc::is_deprecated(property_descriptor) ? nmos::nc_method_status::property_deprecated : nmos::nc_method_status::ok }, nc_object.at(nmos::fields::nc::name(property_descriptor)));`
`511`	`508`
`512`		`- set_reply(res, status_codes::OK, response);`
	`509`	`+ set_reply(res, status_codes::OK, method_result);`
`513`	`510`	`}`
`514`	`511`	`}`
`515`	`512`	`else`