Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The SIGNUPS_ALLOWED setting is not disabling signups #7

Open
bjj opened this issue Mar 1, 2023 · 1 comment
Open

The SIGNUPS_ALLOWED setting is not disabling signups #7

bjj opened this issue Mar 1, 2023 · 1 comment

Comments

@bjj
Copy link

bjj commented Mar 1, 2023

I set up a new install based on this repo and I was able to make a new account. I thought there might be an exception for "first account" so I tested again and could make another. I enabled the admin token and saw that signups were allowed according to the admin page. I disabled them there and verified that I could not create more users.

@bjj
Copy link
Author

bjj commented Mar 1, 2023

I think this is just due to the quoting of 'false'. It also breaks WEBSOCKET_ENABLED which is fixed by changing it from 'true' -> true.

(Websockets may also require expose: 3012 but I didn't test independently)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant