Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from javax.annotations #17

Open
PhilippWendler opened this issue Dec 11, 2017 · 2 comments
Open

Migrate away from javax.annotations #17

PhilippWendler opened this issue Dec 11, 2017 · 2 comments

Comments

@PhilippWendler
Copy link
Member

Guava is moving aways from the annotations in javax.annotations because of some problems with them. We should probably do the same, and as a first step accept the new annotations everywhere where our code checks for existence of the old annotations (e.g., where we check whether something is annotated with @Nullable in Classes).
@PhilippWendler
Copy link
Member Author

Full migration is blocked by SpotBugs support (spotbugs/spotbugs#523).

PhilippWendler added a commit that referenced this issue Jan 8, 2018
@PhilippWendler
Support @NullableDecl in Classes.createFactory
055f2fd 
We want to migrate away from @nullable (#17), and this is a first step.

Furthermore, support all annotations with name Nullable or NullableDecl,
regardless of their package.
This makes it easier for people who cannot use the standard annotations,
because they can just define their own annotations.
@PhilippWendler
Copy link
Member Author

We did the migration in e8e29f7, but we still do not have a solution for @ParametersAreNonnullByDefault (which Guava also still uses).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilippWendler