Skip to content

Commit 0d94b7e

Browse files
daniel-rafflerbaierd
authored andcommitted
Fixed resource leak in SolverThreadLocalityTest. See #345 (comment)
1 parent db0ef27 commit 0d94b7e

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

src/org/sosy_lab/java_smt/test/SolverThreadLocalityTest.java

+14-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import java.util.concurrent.Executors;
1818
import java.util.concurrent.Future;
1919
import java.util.concurrent.TimeUnit;
20+
import org.junit.After;
21+
import org.junit.Before;
2022
import org.junit.Test;
2123
import org.sosy_lab.common.configuration.InvalidConfigurationException;
2224
import org.sosy_lab.java_smt.SolverContextFactory.Solvers;
@@ -32,7 +34,18 @@
3234
import org.sosy_lab.java_smt.solvers.opensmt.Logics;
3335

3436
public class SolverThreadLocalityTest extends SolverBasedTest0.ParameterizedSolverBasedTest0 {
35-
ExecutorService executor = Executors.newFixedThreadPool(2);
37+
private ExecutorService executor;
38+
39+
@Before
40+
public void makeThreads() {
41+
executor = Executors.newFixedThreadPool(2);
42+
}
43+
44+
@After
45+
public void releaseThreads() {
46+
// All threads should have terminated by now as we always wait in the test cases
47+
executor.shutdownNow();
48+
}
3649

3750
@Test
3851
public void allLocalTest() throws InterruptedException, SolverException {

0 commit comments

Comments
 (0)