-
-
Notifications
You must be signed in to change notification settings - Fork 624
The underscore is too low #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Grimy, |
Here is an example of the “thin gray line” behavior, where it looks like only the anti-aliased edge is rendered (zoom-in to see it): The above is the text
At face size 11, the undescore is just pure plain black, so there’s no need for a screenshot. Thanks for your quick reply, it’s good to know that you’re already looking into this kind of issues! |
That indeed is a thin gray line. It isn't even visible in my Chrome, but Photoshop helps. This is indeed unacceptable, but it seems that the character is simply cut off. The underscore itself is positioned fully inside the glyph-box so it should be visible. I am unfamiliar with xterm, but could you see what happens if you define a line-height of 1.25 or greater? See the picture attached; this is where the underscore is supposed to be... |
In xterm’s config, line-height is called “scaleHeight”. As I said in my opening post, setting “scaleHeight” to 1.05 or greater makes the underscore fully visible, but it is still unpleasantly low. Here’s how it looks: I just noticed that I am using an old version of Hack: 552df98 (29 Aug). I’ll try updating to see if it changes anything. |
Yes, please update. : ) |
The problem is not present in Hack-v2_015-ttf. Sorry for the false alert! I’ll close this issue, thanks for your attention (= |
Not a problem! Have a nice day. |
Hack’s
_
is way too low. This was already mentioned in #103 and is also linked to #100.As I understand it, the core of the issue is that “Hack is designed such that underscores appear on the top-most pixels of the next line down.” (quote taken from #100). This supports the historical use of underscores as a way to underline text, but looks visually jarring in
snake_case
, and causes issues in many programs.For example, in xterm, with
faceName: Hack
and all other settings at their default values, non-bold underscores do not render at all. WithfaceSize: 15
andXft.antialias: 1
, underscores look like extremely thin gray lines. As a workaround, settingscaleHeight: 1.05
(or greater) makes the underscores visible again.One could blame xterm for incorrectly assuming that glyphs do not extend beyond the current line, but I believe this is quite a reasonable assumption, and Hack should live up to it (at least for ASCII chars). That’s what other fonts do, that’s what users expect, and it avoids trouble with naïve rendering engines (xterm, IDEA, probably others).
The text was updated successfully, but these errors were encountered: