-
-
Notifications
You must be signed in to change notification settings - Fork 624
Box glyphs don't close vertically #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Mind giving this same block of text a try with this test version that uses tighter vertical spacing? It is renamed 'Hack Tight' so that it can be installed along with the release version. I'll take a look at the position of the glyphs to confirm that this isn't an alignment issue with the glyphs themselves rather than a line spacing issue. |
Close but no cigar. OK, probably in the glyphs themselves. Going to shelve this until I get the vertical spacing issues sorted out or else we would redo it anyways. Will get back on it once I have a stable set of vertical metrics to work with. Will be releasing at least one tighter vert spacing version along with the current spacing down the road. Will let you know when ready. |
Other double line joints also do not quite line up, with ╩ ═ ╧ being a pixel lower than ╔ ╦. I'm using 16 point Hack-Regular. |
Vertical metrics were updated across the entire font with significantly tighter vertical spacing. Mind giving these fonts a try and let me know how close we are on these glyphs? Thanks. Available in #111 |
Note, I'm not using the 'junction' glyphs (mentioned by @msharov), just the 'straights' and 'corners' .. Thanks for your work on this. |
Fantastic. My original vertical metrics changes led to these problems. We have requests for looser spacing variants so we will need to address this down the line. Thank you very much for looking into this issue again. |
I will close this issue when we release these changes unless you have any other associated alignment concerns. Await feedback from @msharov about the other glyph set and will open a separate issue if this is not addressed. |
These vertical spacing changes are now included in v2.015. Thank you very much for the issue report and the testing that you performed on this issue. |
The box glyphs don't form continuous vertical lines .. horizontals are OK. Note the gaps in the vertical lines below (from Xcode). Menlo, SourceCodePro and other "coding" fonts get it right:
The text was updated successfully, but these errors were encountered: