Skip to content

Underscore spacing #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alimsky opened this issue Sep 10, 2015 · 13 comments
Closed

Underscore spacing #97

alimsky opened this issue Sep 10, 2015 · 13 comments
Labels

Comments

@alimsky
Copy link

alimsky commented Sep 10, 2015

It is probably to wide space on the right
and it doesn't feel bold enough. (WebStorm, font-size: 12px)
image

@chrissimpkins
Copy link
Member

Noted. I will take a look at this and get back to you.

@chrissimpkins
Copy link
Member

Any thoughts on the vertical alignment relative to the alphabetic glyphs (and any other glyphs that they are displayed near for that matter)? I've received another issue report (#98) about their orientation with a box glyph below them. They tend to be too tightly spaced with the box glyphs and blend into the character below making the underscore appear to be a space.

@alimsky
Copy link
Author

alimsky commented Sep 13, 2015

Yeah, it's a bit too low. I think it should be higher by own height.
screen-shot-2015-09-13-at-10 28 01-pm
(my version in the bottom)

@chrissimpkins
Copy link
Member

The position of the underscore is too low in the source and it is off center. I will correct these and plan for this change to be in the next release.

Any thoughts on the vertical width of the stroke? Does it seem too narrow to you?

@alimsky
Copy link
Author

alimsky commented Sep 17, 2015

It might be rendering in this particular font size. So, in case you increase to visually match in my case it might be too bold in other font sizes / different platforms. So, it's your call here. I vote for increase though.

@chrissimpkins
Copy link
Member

Will try to have something that we can try soon.

@lots0logs
Copy link

I know its a personal preference, but I don't like the way there is extra space between two underscore characters. I prefer it to appear as though they are connected (best way I can explain it, sorry).

Liberation Mono:
2015-09-19_01-43-52-am

Hack:
2015-09-19_01-44-27-am

@chrissimpkins
Copy link
Member

@lots0logs It's definitely a style issue Dustin. When we correct the centering, we can try to go a bit wider on the glyph itself but I suspect that there will be others out there who like to see the characters for what they are and not as a single glyph (almost a ligature in the Liberation Mono example that you show, it's difficult for me to make those out as separate glyphs). As we test these changes, let's try a few width iterations.

You might want to check out some of the excellent fonts out there that include ligatures (for those who do not know, this is taking two or more characters and combining them into a different, commonly single glyph shape). There are typefaces like Monoid and Fira Code that create attractive ligatures from various character combinations in code. These are great in working fonts but I have concerns about use in a general purpose source code font (one that is aimed at use outside of the editor for web, print, presentations, etc as well) like this one because you eliminate information in the characters when you create ligatures. We are discussing this over in #35 if you'd like to follow or add your thoughts.

@chrissimpkins
Copy link
Member

New test build v2.014 is now available that addresses these issues. I centered the glyphs, made them slightly larger in the vertical dimension, oriented them closer to the baseline, and adjusted the overall vertical metrics of the fonts. @lots0logs - I increased the width of the glyphs based upon your suggestion. The space is slightly apparent still (intentionally) but hopefully brings this closer in line with what you are looking for with the appearance.

Downloads are available in #111

@burodepeper
Copy link
Member

My two €-cents:

  • I'd like the underscore to be the same width/height as the dash (ie, I'd like to be able to count them)
  • I'd like it to rest about its own height underneath the baseline. Or perhaps, directly under the baseline.

@chrissimpkins
Copy link
Member

@burodepeper Mind posting a screenshot with the new v2.014 test build and the text size that you are using?

@burodepeper
Copy link
Member

schermafbeelding 2015-09-21 om 18 33 59
at 14px

@chrissimpkins
Copy link
Member

@burodepeper I increased the spacing between the underscore glyphs for the v2.015 release. Not quite as wide as they were before that build, but the space is more apparent than in the v2.014 test build. This is definitely a glyph where we can consider some alternates as we develop a patch script.

Thanks for this issue report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants