code_style: move platform dependent code to initialize window to namespace SourceGit.Native

love-linger · love-linger · commit ef4b639f8e2e · 2025-05-12T21:52:50.000+08:00
Signed-off-by: leo &lt;longshuang@msn.cn&gt;
diff --git a/src/Native/Linux.cs b/src/Native/Linux.cs
@@ -6,6 +6,7 @@
 
 using Avalonia;
 using Avalonia.Controls;
+using Avalonia.Platform;
 
 namespace SourceGit.Native
 {
@@ -19,7 +20,17 @@ public void SetupApp(AppBuilder builder)
 
         public void SetupWindow(Window window)
         {
-            // Do Nothing.
+            if (OS.UseSystemWindowFrame)
+            {
+                window.ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.Default;
+                window.ExtendClientAreaToDecorationsHint = false;
+            }
+            else
+            {
+                window.ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.NoChrome;
+                window.ExtendClientAreaToDecorationsHint = true;
+                window.Classes.Add("custom_window_frame");
+            }
         }
 
         public string FindGitExecutable()
diff --git a/src/Native/MacOS.cs b/src/Native/MacOS.cs
@@ -6,6 +6,7 @@
 
 using Avalonia;
 using Avalonia.Controls;
+using Avalonia.Platform;
 
 namespace SourceGit.Native
 {
@@ -39,7 +40,8 @@ public void SetupApp(AppBuilder builder)
 
         public void SetupWindow(Window window)
         {
-            // Do Nothing.
+            window.ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.SystemChrome;
+            window.ExtendClientAreaToDecorationsHint = true;
         }
 
         public string FindGitExecutable()
diff --git a/src/Native/OS.cs b/src/Native/OS.cs
@@ -70,6 +70,12 @@ public static List<Models.ExternalTool> ExternalTools
             set;
         } = [];
 
+        public static bool UseSystemWindowFrame
+        {
+            get => OperatingSystem.IsLinux() && _enableSystemWindowFrame;
+            set => _enableSystemWindowFrame = value;
+        }
+
         static OS()
         {
             if (OperatingSystem.IsWindows())
@@ -232,5 +238,6 @@ private static void UpdateGitVersion()
 
         private static IBackend _backend = null;
         private static string _gitExecutable = string.Empty;
+        private static bool _enableSystemWindowFrame = false;
     }
 }
diff --git a/src/Native/Windows.cs b/src/Native/Windows.cs
@@ -8,25 +8,14 @@
 
 using Avalonia;
 using Avalonia.Controls;
+using Avalonia.Platform;
 using Avalonia.Threading;
 
 namespace SourceGit.Native
 {
     [SupportedOSPlatform("windows")]
     internal class Windows : OS.IBackend
     {
-        [StructLayout(LayoutKind.Sequential)]
-        internal struct RTL_OSVERSIONINFOEX
-        {
-            internal uint dwOSVersionInfoSize;
-            internal uint dwMajorVersion;
-            internal uint dwMinorVersion;
-            internal uint dwBuildNumber;
-            internal uint dwPlatformId;
-            [MarshalAs(UnmanagedType.ByValTStr, SizeConst = 128)]
-            internal string szCSDVersion;
-        }
-
         internal struct RECT
         {
             public int left;
@@ -72,9 +61,6 @@ internal struct MARGINS
             public int cyBottomHeight;
         }
 
-        [DllImport("ntdll.dll")]
-        private static extern int RtlGetVersion(ref RTL_OSVERSIONINFOEX lpVersionInformation);
-
         [DllImport("dwmapi.dll")]
         private static extern int DwmExtendFrameIntoClientArea(IntPtr hwnd, ref MARGINS margins);
 
@@ -96,9 +82,7 @@ internal struct MARGINS
         public void SetupApp(AppBuilder builder)
         {
             // Fix drop shadow issue on Windows 10
-            RTL_OSVERSIONINFOEX v = new RTL_OSVERSIONINFOEX();
-            v.dwOSVersionInfoSize = (uint)Marshal.SizeOf<RTL_OSVERSIONINFOEX>();
-            if (RtlGetVersion(ref v) == 0 && (v.dwMajorVersion < 10 || v.dwBuildNumber < 22000))
+            if (!OperatingSystem.IsWindowsVersionAtLeast(10, 22000, 0))
             {
                 Window.WindowStateProperty.Changed.AddClassHandler<Window>((w, _) => FixWindowFrameOnWin10(w));
                 Control.LoadedEvent.AddClassHandler<Window>((w, _) => FixWindowFrameOnWin10(w));
@@ -107,6 +91,10 @@ public void SetupApp(AppBuilder builder)
 
         public void SetupWindow(Window window)
         {
+            window.ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.NoChrome;
+            window.ExtendClientAreaToDecorationsHint = true;
+            window.Classes.Add("fix_maximized_padding");
+
             Win32Properties.AddWndProcHookCallback(window, (IntPtr hWnd, uint msg, IntPtr wParam, IntPtr lParam, ref bool handled) =>
             {
                 // Custom WM_NCHITTEST
diff --git a/src/ViewModels/Preferences.cs b/src/ViewModels/Preferences.cs
@@ -91,8 +91,8 @@ public bool OnlyUseMonoFontInEditor
 
         public bool UseSystemWindowFrame
         {
-            get => _useSystemWindowFrame;
-            set => SetProperty(ref _useSystemWindowFrame, value);
+            get => Native.OS.UseSystemWindowFrame;
+            set => Native.OS.UseSystemWindowFrame = value;
         }
 
         public double DefaultFontSize
@@ -656,7 +656,6 @@ private bool RemoveInvalidRepositoriesRecursive(List<RepositoryNode> collection)
         private string _defaultFontFamily = string.Empty;
         private string _monospaceFontFamily = string.Empty;
         private bool _onlyUseMonoFontInEditor = false;
-        private bool _useSystemWindowFrame = false;
         private double _defaultFontSize = 13;
         private double _editorFontSize = 13;
         private int _editorTabWidth = 4;
diff --git a/src/Views/ChromelessWindow.cs b/src/Views/ChromelessWindow.cs
@@ -3,49 +3,21 @@
 using Avalonia.Controls;
 using Avalonia.Controls.Primitives;
 using Avalonia.Input;
-using Avalonia.Platform;
 
 namespace SourceGit.Views
 {
     public class ChromelessWindow : Window
     {
         public bool UseSystemWindowFrame
         {
-            get => OperatingSystem.IsLinux() && ViewModels.Preferences.Instance.UseSystemWindowFrame;
+            get => Native.OS.UseSystemWindowFrame;
         }
 
         protected override Type StyleKeyOverride => typeof(Window);
 
         public ChromelessWindow()
         {
             Focusable = true;
-
-            if (OperatingSystem.IsLinux())
-            {
-                if (UseSystemWindowFrame)
-                {
-                    ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.Default;
-                    ExtendClientAreaToDecorationsHint = false;
-                }
-                else
-                {
-                    ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.NoChrome;
-                    ExtendClientAreaToDecorationsHint = true;
-                    Classes.Add("custom_window_frame");
-                }
-            }
-            else if (OperatingSystem.IsWindows())
-            {
-                ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.NoChrome;
-                ExtendClientAreaToDecorationsHint = true;
-                Classes.Add("fix_maximized_padding");
-            }
-            else
-            {
-                ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.SystemChrome;
-                ExtendClientAreaToDecorationsHint = true;
-            }
-
             Native.OS.SetupForWindow(this);
         }
 
diff --git a/src/Views/Launcher.axaml b/src/Views/Launcher.axaml
@@ -89,7 +89,7 @@
       <v:LauncherTabBar Grid.Column="2" Height="30" Margin="0,0,16,0" VerticalAlignment="Bottom"/>
 
       <!-- Caption Buttons (Windows/Linux)-->
-      <Border Grid.Column="3" Margin="16,0,0,0" IsVisible="{Binding #ThisControl.IsRightCaptionButtonsVisible}">
+      <Border Grid.Column="3" Margin="16,0,0,0" IsVisible="{Binding #ThisControl.HasRightCaptionButton}">
         <v:CaptionButtons Height="30" VerticalAlignment="Top"/>
       </Border>
     </Grid>
diff --git a/src/Views/Launcher.axaml.cs b/src/Views/Launcher.axaml.cs
@@ -29,14 +29,9 @@ public bool HasLeftCaptionButton
             set => SetValue(HasLeftCaptionButtonProperty, value);
         }
 
-        public bool IsRightCaptionButtonsVisible
+        public bool HasRightCaptionButton
         {
-            get
-            {
-                if (OperatingSystem.IsLinux())
-                    return !ViewModels.Preferences.Instance.UseSystemWindowFrame;
-                return OperatingSystem.IsWindows();
-            }
+            get => OperatingSystem.IsWindows() || !Native.OS.UseSystemWindowFrame;
         }
 
         public Launcher()
@@ -52,8 +47,7 @@ public Launcher()
             {
                 HasLeftCaptionButton = true;
                 CaptionHeight = new GridLength(34);
-                ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.SystemChrome |
-                                              ExtendClientAreaChromeHints.OSXThickTitleBar;
+                ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.SystemChrome | ExtendClientAreaChromeHints.OSXThickTitleBar;
             }
             else if (UseSystemWindowFrame)
             {
diff --git a/src/Views/Preferences.axaml b/src/Views/Preferences.axaml
@@ -129,23 +129,23 @@
             <CheckBox Grid.Row="5" Grid.Column="1"
                       Height="32"
                       Content="{DynamicResource Text.Preferences.General.ShowAuthorTime}"
-                      IsChecked="{Binding Source={x:Static vm:Preferences.Instance}, Path=ShowAuthorTimeInGraph, Mode=TwoWay}"/>
+                      IsChecked="{Binding ShowAuthorTimeInGraph, Mode=TwoWay}"/>
 
             <CheckBox Grid.Row="6" Grid.Column="1"
                       Height="32"
                       Content="{DynamicResource Text.Preferences.General.ShowTagsInGraph}"
-                      IsChecked="{Binding Source={x:Static vm:Preferences.Instance}, Path=ShowTagsInGraph, Mode=TwoWay}"/>
+                      IsChecked="{Binding ShowTagsInGraph, Mode=TwoWay}"/>
 
             <CheckBox Grid.Row="7" Grid.Column="1"
                       Height="32"
                       Content="{DynamicResource Text.Preferences.General.ShowChildren}"
-                      IsChecked="{Binding Source={x:Static vm:Preferences.Instance}, Path=ShowChildren, Mode=TwoWay}"/>
+                      IsChecked="{Binding ShowChildren, Mode=TwoWay}"/>
 
             <CheckBox Grid.Row="8" Grid.Column="1"
                       Height="32"
                       Content="{DynamicResource Text.Preferences.General.Check4UpdatesOnStartup}"
                       IsVisible="{x:Static s:App.IsCheckForUpdateCommandVisible}"
-                      IsChecked="{Binding Source={x:Static vm:Preferences.Instance}, Path=Check4UpdatesOnStartup, Mode=TwoWay}"/>
+                      IsChecked="{Binding Check4UpdatesOnStartup, Mode=TwoWay}"/>
           </Grid>
         </TabItem>
 
@@ -257,12 +257,12 @@
             <CheckBox Grid.Row="7" Grid.Column="1"
                       Height="32"
                       Content="{DynamicResource Text.Preferences.Appearance.UseFixedTabWidth}"
-                      IsChecked="{Binding Source={x:Static vm:Preferences.Instance}, Path=UseFixedTabWidth, Mode=TwoWay}"/>
+                      IsChecked="{Binding UseFixedTabWidth, Mode=TwoWay}"/>
 
             <CheckBox Grid.Row="8" Grid.Column="1"
                       Height="32"
                       Content="{DynamicResource Text.Preferences.Appearance.UseNativeWindowFrame}"
-                      IsChecked="{Binding Source={x:Static vm:Preferences.Instance}, Path=UseSystemWindowFrame, Mode=OneTime}"
+                      IsChecked="{Binding UseSystemWindowFrame, Mode=OneTime}"
                       IsVisible="{OnPlatform False, Linux=True}"
                       IsCheckedChanged="OnUseNativeWindowFrameChanged"/>
           </Grid>

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`
`7`	`7`	`using Avalonia;`
`8`	`8`	`using Avalonia.Controls;`
	`9`	`+using Avalonia.Platform;`
`9`	`10`
`10`	`11`	`namespace SourceGit.Native`
`11`	`12`	`{`
`@@ -39,7 +40,8 @@ public void SetupApp(AppBuilder builder)`
`39`	`40`
`40`	`41`	`public void SetupWindow(Window window)`
`41`	`42`	`{`
`42`		`- // Do Nothing.`
	`43`	`+ window.ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.SystemChrome;`
	`44`	`+ window.ExtendClientAreaToDecorationsHint = true;`
`43`	`45`	`}`
`44`	`46`
`45`	`47`	`public string FindGitExecutable()`
Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,12 @@ public static List<Models.ExternalTool> ExternalTools`
`70`	`70`	`set;`
`71`	`71`	`} = [];`
`72`	`72`
	`73`	`+ public static bool UseSystemWindowFrame`
	`74`	`+ {`
	`75`	`+ get => OperatingSystem.IsLinux() && _enableSystemWindowFrame;`
	`76`	`+ set => _enableSystemWindowFrame = value;`
	`77`	`+ }`
	`78`	`+`
`73`	`79`	`static OS()`
`74`	`80`	`{`
`75`	`81`	`if (OperatingSystem.IsWindows())`
`@@ -232,5 +238,6 @@ private static void UpdateGitVersion()`
`232`	`238`
`233`	`239`	`private static IBackend _backend = null;`
`234`	`240`	`private static string _gitExecutable = string.Empty;`
	`241`	`+ private static bool _enableSystemWindowFrame = false;`
`235`	`242`	`}`
`236`	`243`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,14 +29,9 @@ public bool HasLeftCaptionButton`
`29`	`29`	`set => SetValue(HasLeftCaptionButtonProperty, value);`
`30`	`30`	`}`
`31`	`31`
`32`		`- public bool IsRightCaptionButtonsVisible`
	`32`	`+ public bool HasRightCaptionButton`
`33`	`33`	`{`
`34`		`- get`
`35`		`- {`
`36`		`- if (OperatingSystem.IsLinux())`
`37`		`- return !ViewModels.Preferences.Instance.UseSystemWindowFrame;`
`38`		`- return OperatingSystem.IsWindows();`
`39`		`- }`
	`34`	`+ get => OperatingSystem.IsWindows() \|\| !Native.OS.UseSystemWindowFrame;`
`40`	`35`	`}`
`41`	`36`
`42`	`37`	`public Launcher()`
`@@ -52,8 +47,7 @@ public Launcher()`
`52`	`47`	`{`
`53`	`48`	`HasLeftCaptionButton = true;`
`54`	`49`	`CaptionHeight = new GridLength(34);`
`55`		`- ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.SystemChrome \|`
`56`		`- ExtendClientAreaChromeHints.OSXThickTitleBar;`
	`50`	`+ ExtendClientAreaChromeHints = ExtendClientAreaChromeHints.SystemChrome \| ExtendClientAreaChromeHints.OSXThickTitleBar;`
`57`	`51`	`}`
`58`	`52`	`else if (UseSystemWindowFrame)`
`59`	`53`	`{`