Implements support for the enclosing_range field in SCIP occurrences,
#504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enabling IDE features like: - Call hierarchies (determining symbol references within function bodies) - Symbol outline/breadcrumbs (showing path from cursor to file root) - Expand selection (selecting nearest enclosing AST node) - Highlight range (indicating AST expression boundaries for hovers) ## Changes ### 1. Updated SCIP Dependency Updated to SCIP commit `9d5796159c97c3b107355c424f6c06fb1a0ea01c` which includes: - The `enclosing_range` field definition in the protobuf schema - The `add_enclosing_range()` API for populating individual values ### 2. Extended Indexer API Added `clang::SourceRange enclosingRange` parameter (with default empty value) to: - `TuIndexer::saveDefinition()` - `TuIndexer::saveReference()` - `TuIndexer::saveOccurrence()` - `TuIndexer::saveOccurrenceImpl()` ### 3. Implemented Range Population Modified `saveOccurrenceImpl()` to populate the `enclosing_range` field: - Format: `[startLine-1, startColumn-1, [endLine-1], endColumn-1]` - Uses 0-based coordinates as per SCIP specification - Omits endLine if range is single-line - Only populates when valid range is provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for the
enclosing_rangefield in SCIP occurrences, enabling IDE features like:Changes
1. Updated SCIP Dependency
Updated schema to SCIP commit
9d5796159c97c3b107355c424f6c06fb1a0ea01cwhich includes:
enclosing_rangefield definition in the protobuf schemaadd_enclosing_range()API for populating individual values2. Extended Indexer API
Added
clang::SourceRange enclosingRangeparameter (with defaultempty value) to:
TuIndexer::saveDefinition()TuIndexer::saveReference()TuIndexer::saveOccurrence()TuIndexer::saveOccurrenceImpl()3. Implemented Range Population
Modified
saveOccurrenceImpl()to populate theenclosing_rangefield:
[startLine-1, startColumn-1, [endLine-1], endColumn-1]