Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit 2fd375f

Browse files
authored
Revert #59723 (login with SAMS-dev) (#60535)
1 parent 2606bc0 commit 2fd375f

File tree

3 files changed

+0
-268
lines changed

3 files changed

+0
-268
lines changed

client/web/src/auth/SignInPage.test.tsx

-29
Original file line numberDiff line numberDiff line change
@@ -143,35 +143,6 @@ describe('SignInPage', () => {
143143
expect(rendered.asFragment()).toMatchSnapshot()
144144
})
145145

146-
describe('with Sourcegraph accounts (dev) auth provider', () => {
147-
const samsProviderName = 'Sourcegraph Accounts (dev) [Testing Only]'
148-
const withSourcegraphAccountsDev: SourcegraphContext['authProviders'] = [
149-
...authProviders,
150-
{
151-
displayName: samsProviderName,
152-
isBuiltin: false,
153-
serviceType: 'openidconnect',
154-
authenticationURL: 'https://accounts.sgdev.org/.auth/openidconnect/',
155-
serviceID: 'https://accounts.sgdev.org',
156-
clientID: 'sams-dev_cid_xxxx',
157-
},
158-
]
159-
160-
it('renders page with 2 providers', () => {
161-
const rendered = render('/sign-in', { authProviders: withSourcegraphAccountsDev })
162-
expect(
163-
within(rendered.baseElement).queryByText(txt => txt.includes(samsProviderName))
164-
).not.toBeInTheDocument()
165-
expect(rendered.asFragment()).toMatchSnapshot()
166-
})
167-
168-
it('renders page with 3 providers (url-param present)', () => {
169-
const rendered = render('/sign-in?sourcegraph-accounts-dev', { authProviders: withSourcegraphAccountsDev })
170-
expect(within(rendered.baseElement).queryByText(txt => txt.includes(samsProviderName))).toBeInTheDocument()
171-
expect(rendered.asFragment()).toMatchSnapshot()
172-
})
173-
})
174-
175146
describe('with Sourcegraph operator auth provider', () => {
176147
const withSourcegraphOperator: SourcegraphContext['authProviders'] = [
177148
...authProviders,

client/web/src/auth/SignInPage.tsx

-13
Original file line numberDiff line numberDiff line change
@@ -60,21 +60,8 @@ export const SignInPage: React.FunctionComponent<React.PropsWithChildren<SignInP
6060
)
6161

6262
const shouldShowProvider = function (provider: AuthProvider): boolean {
63-
const isSourcegraphAccountsDev = (provider: AuthProvider): boolean => {
64-
if (provider.serviceType !== 'openidconnect') {
65-
return false
66-
}
67-
if (!provider.displayName.includes('Sourcegraph Accounts (dev)')) {
68-
return false
69-
}
70-
return true
71-
}
72-
7363
// Hide the Sourcegraph Operator authentication provider by default because it is
7464
// not useful to customer users and may even cause confusion.
75-
if (isSourcegraphAccountsDev(provider)) {
76-
return searchParams.has('sourcegraph-accounts-dev')
77-
}
7865
if (provider.serviceType === 'sourcegraph-operator') {
7966
return searchParams.has('sourcegraph-operator')
8067
}

client/web/src/auth/__snapshots__/SignInPage.test.tsx.snap

-226
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)