reapply "switch from jest to vitest for faster, simpler tests (#57886)" (#58145)

* reapply "switch from jest to vitest for faster, simpler tests (https://github.com/sourcegraph/sourcegraph/pull/57886)"

This was reverted in https://github.com/sourcegraph/sourcegraph/pull/58116 due to an issue with the browser tests.

* include fetch-mock

* fix flakiness

* rm mock that did not work in experimentalVmThreads

* fix

* timeout

* fixup

---------

Co-authored-by: William Bezuidenhout <[email protected]>

Author: sqs

Diff for: .eslintrc.js

@@ -22,7 +22,6 @@ const config = {
     '**/*.json',
     '**/*.d.ts',
     'eslint-relative-formatter.js',
-    'jest.config.js',
     'typedoc.js',
     'bundlesize.config.js',
   ],
@@ -135,6 +134,7 @@ See https://handbook.sourcegraph.com/community/faq#is-all-of-sourcegraph-open-so
               '!@sourcegraph/*/src/stories',
               '!@sourcegraph/build-config/src/esbuild/*',
               '!@sourcegraph/build-config/src/*',
+              '!@sourcegraph/testing/src/jestDomMatchers',
             ],
             message:
               'Imports from package internals are banned. Add relevant export to the entry point of the package to import it from the outside world.',

Diff for: .mocharc.js

@@ -5,7 +5,7 @@ module.exports = {
   require: [
     ...(IS_BAZEL ? [] : ['ts-node/register/transpile-only']),
     'abort-controller/polyfill',
-    rootDir + '/client/shared/dev/fetch',
+    rootDir + '/client/testing/src/fetch',
     rootDir + '/client/shared/dev/suppressPollyErrors',
   ],
   reporter: rootDir + '/client/shared/dev/customMochaSpecReporter.js',

Diff for: .vscode/extensions.json

@@ -11,7 +11,6 @@
     "exiasr.hadolint",
     "bierner.markdown-mermaid",
     "ecmel.vscode-html-css",
-    "orta.vscode-jest",
     "dbaeumer.vscode-eslint",
     "foxundermoon.shell-format",
     "timonwong.shellcheck",

Diff for: .vscode/launch.json

@@ -74,28 +74,6 @@
         "E2E_BROWSER": "chrome"
       }
     },
-    {
-      "type": "node",
-      "name": "vscode-jest-tests",
-      "request": "launch",
-      "program": "${workspaceFolder}/node_modules/jest/bin/jest",
-      "args": [
-        "--color",
-        "--runInBand"
-        // "path/to/test/file",
-        // "-t",
-        // "test name",
-      ],
-      "cwd": "${workspaceFolder}",
-      "console": "integratedTerminal",
-      "internalConsoleOptions": "neverOpen",
-      "skipFiles": [
-        "**/async_hooks.js",
-        "**/inspector_async_hook.js"
-        // "**/node_modules/rxjs",
-      ],
-      "smartStep": false
-    },
     {
       "name": "Webapp Chrome",
       "type": "chrome",

Diff for: .vscode/settings.json

@@ -37,7 +37,6 @@
     "build.allowImplicitNetworkAccess": true,
     "local": "github.com/sourcegraph/sourcegraph"
   },
-  "jest.jestCommandLine": "pnpm run test",
   "npm.packageManager": "pnpm",
   "npm.runSilent": true,
   "typescript.preferences.quoteStyle": "single",

Diff for: BUILD.bazel

@@ -83,58 +83,20 @@ copy_to_bin(
 )
 
 js_library(
-    name = "jest_config",
+    name = "vitest_config",
     testonly = True,
     srcs = [
-        "jest.config.base.js",
-    ],
-    data = [
-        "jest.snapshot-resolver.js",
+        "vitest.shared.ts",
     ],
     visibility = ["//visibility:public"],
     deps = [
-        ":babel_config_jest",
         "//:node_modules/@testing-library/jest-dom",
         "//:node_modules/abort-controller",
-        "//:node_modules/babel-jest",
         "//:node_modules/core-js",
         "//:node_modules/identity-obj-proxy",
         "//:node_modules/message-port-polyfill",
         "//:node_modules/regenerator-runtime",
-        "//client/shared/dev:mock",
-    ],
-)
-
-js_library(
-    name = "babel_config_jest",
-    testonly = True,
-    srcs = [
-        "babel.config.jest.js",
-    ],
-    visibility = ["//visibility:public"],
-    deps = [
-        "//:node_modules/@babel/preset-env",
-        "//:node_modules/@babel/runtime",
-        "//:node_modules/signale",
-    ],
-)
-
-js_library(
-    name = "babel_config",
-    srcs = [
-        "babel.config.js",
-    ],
-    data = [
-        ":package_json",
-    ],
-    visibility = ["//visibility:public"],
-    deps = [
-        "//:node_modules/@babel/preset-env",
-        "//:node_modules/@babel/preset-react",
-        "//:node_modules/@babel/preset-typescript",
-        "//:node_modules/@babel/runtime",
-        "//:node_modules/semver",
-        "//:node_modules/signale",
+        "//client/testing:testing_lib",
     ],
 )
 
@@ -146,9 +108,9 @@ js_library(
     ],
     deps = [
         "//:node_modules/abort-controller",
-        "//client/shared/dev:fetch-mock",
         "//client/shared/dev:mocha-reporter",
         "//client/shared/dev:suppress-polly-errors",
+        "//client/testing:fetch-mock",
     ],
 )
 

Diff for: WORKSPACE

@@ -42,13 +42,6 @@ http_archive(
     url = "https://github.com/aspect-build/rules_ts/releases/download/v2.0.0/rules_ts-v2.0.0.tar.gz",
 )
 
-http_archive(
-    name = "aspect_rules_jest",
-    sha256 = "bf8f4a4d2a833e4f96f866c686c38bcee69d3bdae8a827b1c9d2fdf92212bc0b",
-    strip_prefix = "rules_jest-95d8f1961a9c6f3aee2929881b1b74461652e775",
-    url = "https://github.com/aspect-build/rules_jest/archive/95d8f1961a9c6f3aee2929881b1b74461652e775.tar.gz",
-)
-
 http_archive(
     name = "aspect_rules_swc",
     sha256 = "8eb9e42ed166f20cacedfdb22d8d5b31156352eac190fc3347db55603745a2d8",
@@ -197,22 +190,6 @@ load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies")
 
 rules_ts_dependencies(ts_version = "4.9.5")
 
-# rules_jest setup ==============================
-load("@aspect_rules_jest//jest:dependencies.bzl", "rules_jest_dependencies")
-
-rules_jest_dependencies()
-
-load("@aspect_rules_jest//jest:repositories.bzl", "jest_repositories")
-
-jest_repositories(
-    name = "jest",
-    jest_version = "v28.1.0",
-)
-
-load("@jest//:npm_repositories.bzl", jest_npm_repositories = "npm_repositories")
-
-jest_npm_repositories()
-
 # rules_swc setup ==============================
 load("@aspect_rules_swc//swc:dependencies.bzl", "rules_swc_dependencies")
 

Diff for: babel.config.jest.js

@@ -5,7 +5,7 @@
 # gazelle:js_files globals.d.ts
 
 # Test files, snapshots etc:
-# gazelle:js_test_files **/*.{spec,test}.{ts,tsx}
+# gazelle:js_test_files **/*.test.{ts,tsx}
 # gazelle:js_test_files **/mock*.{ts,tsx}
 # gazelle:js_test_files **/*.{mock,mocks}.{ts,tsx}
 # gazelle:js_test_files **/mocks/**
@@ -16,6 +16,10 @@
 # gazelle:js_test_files **/WebStory.{ts,tsx}
 # TODO(bazel): sveltekit tests
 # gazelle:exclude **/web-sveltekit/**/*.ts
+# gazelle:exclude **/vitest.config.ts
+
+# Otherwise it gets tripped up on the `declare module 'vitest'` directives to add custom matchers.
+# gazelle:js_resolve vitest //:node_modules/vitest
 
 # TODO(bazel): put fixtures + testutils + ? into own rules
 # js_{fixture}_files **/*.{fixture,fixtures}.{ts,tsx}

Diff for: babel.config.js

@@ -2,10 +2,6 @@
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
     "module": "esnext",
-    "baseUrl": ".",
-    "paths": {
-      "*": ["src/types/*", "../shared/src/types/*", "../common/src/types/*", "*"],
-    },
     "jsx": "react-jsx",
     "rootDir": "./src",
     "outDir": "out",

Diff for: client/BUILD.bazel

@@ -1,11 +1,10 @@
 load("@npm//:defs.bzl", "npm_link_all_packages")
-load("//dev:defs.bzl", "jest_test", "npm_package", "sass", "ts_project")
+load("//dev:defs.bzl", "npm_package", "sass", "ts_project", "vitest_test")
 load("//client/shared/dev:tools.bzl", "module_style_typings")
 load("//dev:eslint.bzl", "eslint_config_and_lint_root", "eslint_test_with_types")
 
 # TODO(bazel): storybook build
 # gazelle:exclude **/*.story.{ts,tsx}
-# gazelle:exclude **/testGlobals.d.ts
 
 # gazelle:js_resolve **/*.module.scss :module_style_typings
 
@@ -25,7 +24,6 @@ eslint_test_with_types(
     ]),
     config = ":eslint_config",
     deps = [
-        "//:jest_config",  # required for import/extensions rule not to fail on the `jest.config.base` import.
         "//:node_modules/@types/node",
     ],
 )
@@ -36,8 +34,6 @@ ts_config(
     visibility = ["//client:__subpackages__"],
     deps = [
         "//:tsconfig",
-        "//client/client-api:tsconfig",
-        "//client/codeintellify:tsconfig",
         "//client/common:tsconfig",
         "//client/extension-api-types:tsconfig",
         "//client/observability-client:tsconfig",
@@ -170,7 +166,6 @@ ts_project(
     tsconfig = ":tsconfig",
     deps = [
         ":module_style_typings",
-        ":node_modules/@sourcegraph/codeintellify",  #keep
         ":node_modules/@sourcegraph/common",
         ":node_modules/@sourcegraph/http-client",
         ":node_modules/@sourcegraph/observability-client",
@@ -191,7 +186,6 @@ ts_project(
         "//:node_modules/@types/react",
         "//:node_modules/@types/react-dom",
         "//:node_modules/classnames",
-        "//:node_modules/comlink",  #keep
         "//:node_modules/copy-to-clipboard",
         "//:node_modules/date-fns",
         "//:node_modules/dompurify",
@@ -241,7 +235,7 @@ ts_project(
         "src/search-ui/results/sidebar/SearchFilterSection.test.tsx",
         "src/search-ui/results/sidebar/helpers.test.ts",
         "src/search-ui/results/use-items-to-show.test.ts",
-        "src/testGlobals.d.ts",  #keep
+        "src/testSetup.test.ts",
     ],
     tsconfig = ":tsconfig",
     deps = [
@@ -251,7 +245,6 @@ ts_project(
         ":node_modules/@sourcegraph/wildcard",
         "//:node_modules/@codemirror/autocomplete",
         "//:node_modules/@codemirror/state",
-        "//:node_modules/@jest/globals",
         "//:node_modules/@testing-library/jest-dom",  #keep
         "//:node_modules/@testing-library/react",
         "//:node_modules/@testing-library/user-event",
@@ -267,6 +260,7 @@ ts_project(
         "//:node_modules/react-dom",
         "//:node_modules/rxjs",
         "//:node_modules/sinon",
+        "//:node_modules/vitest",
     ],
 )
 
@@ -279,13 +273,16 @@ npm_package(
     ],
 )
 
-jest_test(
+filegroup(
+    name = "snapshots",
+    srcs = glob(["src/**/__snapshots__/*"]),
+)
+
+vitest_test(
     name = "test",
     timeout = "long",
     data = [
         ":branded_tests",
+        ":snapshots",
     ],
-    patch_node_fs = False,
-    shard_count = 6,
-    tags = ["no-sandbox"],
 )

Diff for: client/app-shell/tsconfig.json

@@ -9,15 +9,13 @@
     "storybook": "STORIES_GLOB='client/branded/src/**/*.story.tsx' pnpm --filter @sourcegraph/storybook run start",
     "lint:js": "eslint --cache '**/*.[jt]s?(x)'",
     "lint:css": "stylelint 'src/**/*.scss' --quiet",
-    "test": "jest"
+    "test": "vitest"
   },
   "devDependencies": {
     "@sourcegraph/extension-api-types": "workspace:*",
     "@sourcegraph/testing": "workspace:*"
   },
   "dependencies": {
-    "@sourcegraph/client-api": "workspace:*",
-    "@sourcegraph/codeintellify": "workspace:*",
     "@sourcegraph/common": "workspace:*",
     "@sourcegraph/observability-client": "workspace:*",
     "@sourcegraph/shared": "workspace:*",