fix: end stream in connection.end

soxhub · Apr 4, 2018 · 4077178 · 4077178
1 parent d4aa616
commit 4077178
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/lib/connection.js b/lib/connection.js
@@ -328,6 +328,7 @@ Connection.prototype.end = function() {
   this.writer.add(emptyBuffer);
   this._ending = true;
   this._send(0x58);
+  this.stream.end();
 };
 
 Connection.prototype.close = function(msg, more) {

diff --git a/test/unit/connection/outbound-sending-tests.js b/test/unit/connection/outbound-sending-tests.js
@@ -183,6 +183,7 @@ test('sends end command', function() {
   con.end();
   var expected = new Buffer([0x58, 0, 0, 0, 4]);
   assert.received(stream, expected);
+  assert.equal(stream.closed, true);
 });
 
 test('sends describe command',function() {

diff --git a/test/unit/test-helper.js b/test/unit/test-helper.js
@@ -15,8 +15,13 @@ p.write = function(packet) {
   this.packets.push(packet);
 };
 
+p.end = function() {
+  p.closed = true;
+}
+
 p.setKeepAlive = function(){};
 
+p.closed = false;
 p.writable = true;
 
 createClient = function() {