From 7126d6d251f71798e459f658c6bf2a762fe17870 Mon Sep 17 00:00:00 2001
From: Ivan Perez <ivan.perezdominguez@nasa.gov>
Date: Fri, 31 Jan 2025 15:11:08 -0800
Subject: [PATCH] Pin Navigation2 demo to humble-2024.10.0 (#197)

The current dockerfile of the navigation2 demo depends on space-ros:latest.
This may prevent the image from building if we release a new version of Space
ROS but we have not yet adapted the Navigation 2 demo as needed, breaking the
build.

This commit pins the version of the Navigation 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0). We modify both the
Dockerfile and the build script so that the result is the same (and thus
unsurprising) no matter how the image is built.
---
 navigation2/Dockerfile | 2 +-
 navigation2/build.sh   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/navigation2/Dockerfile b/navigation2/Dockerfile
index 6c6f2d7..15b9a69 100644
--- a/navigation2/Dockerfile
+++ b/navigation2/Dockerfile
@@ -20,7 +20,7 @@
 #   VERSION         - The version of Space ROS (default: "preview")
 #   SPACE_ROS_IMAGE - The base Space ROS image to build on
 
-ARG SPACE_ROS_IMAGE=osrf/space-ros:latest
+ARG SPACE_ROS_IMAGE=osrf/space-ros:humble-2024.10.0
 
 FROM ${SPACE_ROS_IMAGE}
 
diff --git a/navigation2/build.sh b/navigation2/build.sh
index 36b0a73..161226f 100755
--- a/navigation2/build.sh
+++ b/navigation2/build.sh
@@ -17,7 +17,7 @@ echo ""
 docker build -t $ORG/$IMAGE:$TAG \
     --build-arg VCS_REF="$VCS_REF" \
     --build-arg VERSION="$VERSION" \
-    --build-arg SPACE_ROS_IMAGE="${SPACE_ROS_IMAGE:-osrf/space-ros:latest}" \
+    --build-arg SPACE_ROS_IMAGE="${SPACE_ROS_IMAGE:-osrf/space-ros:humble-2024.10.0}" \
     .
 
 echo ""