Skip to content

Commit 637a82d

Browse files
authored
fix: Watch log hangs when we're in a terminal state (#251)
1 parent 4c916ad commit 637a82d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

internal/cmd/stack/run_logs.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func runStates(ctx context.Context, stack, run string, sink chan<- string, acFn
128128
fmt.Println("")
129129

130130
if transition.HasLogs {
131-
if err := runStateLogs(ctx, stack, run, transition.State, transition.StateVersion, sink); err != nil {
131+
if err := runStateLogs(ctx, stack, run, transition.State, transition.StateVersion, sink, transition.Terminal); err != nil {
132132
return nil, err
133133
}
134134
}
@@ -152,7 +152,7 @@ func runStates(ctx context.Context, stack, run string, sink chan<- string, acFn
152152
}
153153
}
154154

155-
func runStateLogs(ctx context.Context, stack, run string, state structs.RunState, version int, sink chan<- string) error {
155+
func runStateLogs(ctx context.Context, stack, run string, state structs.RunState, version int, sink chan<- string, stateTerminal bool) error {
156156
var query struct {
157157
Stack *struct {
158158
Run *struct {
@@ -204,7 +204,7 @@ func runStateLogs(ctx context.Context, stack, run string, state structs.RunState
204204
sink <- message.Body
205205
}
206206

207-
if logs.Finished {
207+
if logs.Finished || (!logs.HasMore && stateTerminal) {
208208
break
209209
}
210210

0 commit comments

Comments
 (0)