From 741fd88a3b9ae3ec4eaa8172780af981df270cff Mon Sep 17 00:00:00 2001
From: Michal Wasilewski <michal@mwasilewski.net>
Date: Mon, 22 Jan 2024 17:02:28 +0100
Subject: [PATCH] feat(security-email): remove tests which run the delete
 function

Signed-off-by: Michal Wasilewski <michal@mwasilewski.net>
---
 spacelift/resource_security_email.go      |  4 +--
 spacelift/resource_security_email_test.go | 38 -----------------------
 2 files changed, 2 insertions(+), 40 deletions(-)
 delete mode 100644 spacelift/resource_security_email_test.go

diff --git a/spacelift/resource_security_email.go b/spacelift/resource_security_email.go
index 532e9297..4b48bc6b 100644
--- a/spacelift/resource_security_email.go
+++ b/spacelift/resource_security_email.go
@@ -8,9 +8,9 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
 	"github.com/spacelift-io/terraform-provider-spacelift/spacelift/internal"
-	"github.com/spacelift-io/terraform-provider-spacelift/spacelift/internal/structs"
 )
 
+// There are no tests for this resource because terraform sdk tests run delete function after each test: https://github.com/hashicorp/terraform-plugin-sdk/blob/bb132acb576c8a4b61ee2b5f86f6d9ec51c0e538/helper/resource/testing_new.go#L79
 func resourceSecurityEmail() *schema.Resource {
 	return &schema.Resource{
 		Description: "" +
@@ -53,7 +53,7 @@ func resourceSecurityEmailCreate(ctx context.Context, data *schema.ResourceData,
 
 func resourceSecurityEmailRead(ctx context.Context, data *schema.ResourceData, i interface{}) diag.Diagnostics {
 	var query struct {
-		SecurityEmail *structs.SecurityEmail `graphql:"securityEmail"`
+		SecurityEmail *string `graphql:"securityEmail"`
 	}
 	if err := i.(*internal.Client).Query(ctx, "SecurityEmail", &query, nil); err != nil {
 		return diag.Errorf("could not query for security email: %v", err)
diff --git a/spacelift/resource_security_email_test.go b/spacelift/resource_security_email_test.go
deleted file mode 100644
index fd7a3484..00000000
--- a/spacelift/resource_security_email_test.go
+++ /dev/null
@@ -1,38 +0,0 @@
-package spacelift
-
-import (
-	"fmt"
-	"testing"
-
-	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
-
-	. "github.com/spacelift-io/terraform-provider-spacelift/spacelift/internal/testhelpers"
-)
-
-var securityEmailSimple = `
-resource "spacelift_security_email" "test" {
-	email = "%s"
-}
-`
-
-func Test_resourceSecurityEmail(t *testing.T) {
-	const resourceName = "spacelift_resource_security_email.test"
-
-	t.Run("creates a security email without an error", func(t *testing.T) {
-		exampleEmail := "user3@example.com"
-		testSteps(t, []resource.TestStep{
-			{
-				Config: fmt.Sprintf(securityEmailSimple, exampleEmail),
-				Check: Resource(
-					resourceName,
-					Attribute("email", Equals(exampleEmail)),
-				),
-			},
-			{
-				ResourceName:      resourceName,
-				ImportState:       true,
-				ImportStateVerify: true,
-			},
-		})
-	})
-}