clippy

Author: jupyterkat

crates/byondapi-macros/src/lib.rs

@@ -52,7 +52,7 @@ pub fn bind(attr: TokenStream, item: TokenStream) -> TokenStream {
         .filter_map(|attr| match &attr.meta {
             syn::Meta::NameValue(nameval) => {
                 let ident = nameval.path.get_ident()?;
-                if ident.to_string() == "doc".to_string() {
+                if *ident == "doc" {
                     match &nameval.value {
                         syn::Expr::Lit(literal) => match &literal.lit {
                             syn::Lit::Str(docstring) => {
@@ -217,7 +217,7 @@ pub fn bind_raw_args(attr: TokenStream, item: TokenStream) -> TokenStream {
         .filter_map(|attr| match &attr.meta {
             syn::Meta::NameValue(nameval) => {
                 let ident = nameval.path.get_ident()?;
-                if ident.to_string() == "doc".to_string() {
+                if *ident == "doc" {
                     match &nameval.value {
                         syn::Expr::Lit(literal) => match &literal.lit {
                             syn::Lit::Str(docstring) => {

crates/byondapi-rs/src/binds.rs

@@ -61,25 +61,23 @@ pub fn generate_bindings(libname: &str) {
 "#
             ))
             .unwrap()
-        } else {
-            if cfg!(feature = "byond-515-1621") {
-                file.write_fmt(format_args!(
-                    r#"{docs}{path}({func_arguments_srcless})
+        } else if cfg!(feature = "byond-515-1621") {
+            file.write_fmt(format_args!(
+                r#"{docs}{path}({func_arguments_srcless})
 	return call_ext({libname_upper}, "byond:{func_name}")({func_arguments})
 
 "#
-                ))
-                .unwrap()
-            } else {
-                file.write_fmt(format_args!(
-                    r#"{docs}{path}({func_arguments_srcless})
+            ))
+            .unwrap()
+        } else {
+            file.write_fmt(format_args!(
+                r#"{docs}{path}({func_arguments_srcless})
 	var/static/loaded = load_ext({libname_upper}, "byond:{func_name}")
 	return call_ext(loaded)({func_arguments})
 
 "#
-                ))
-                .unwrap()
-            }
+            ))
+            .unwrap()
         }
     }
 }

crates/byondapi-rs/src/value/functions.rs

@@ -316,7 +316,7 @@ struct ValueIterator<'a> {
     len: u32,
     ctr: u32,
 }
-impl<'a> Iterator for ValueIterator<'a> {
+impl Iterator for ValueIterator<'_> {
     type Item = ByondValue;
     fn next(&mut self) -> Option<Self::Item> {
         if self.ctr <= self.len {
@@ -340,7 +340,7 @@ struct ListIterator<'a> {
     len: u32,
     ctr: u32,
 }
-impl<'a> Iterator for ListIterator<'a> {
+impl Iterator for ListIterator<'_> {
     type Item = (ByondValue, ByondValue);
     fn next(&mut self) -> Option<Self::Item> {
         if self.ctr <= self.len {