From c1ae34c67e3cd8fdf6edc4df090314d6c3964201 Mon Sep 17 00:00:00 2001
From: visuve <veli-matti.visuri@iki.fi>
Date: Sat, 12 Feb 2022 18:01:10 +0200
Subject: [PATCH] Improve CAN_Read_Demo.ino

- The code was messy
- The message buffer was not initialized
---
 examples/CAN_Read_Demo/CAN_Read_Demo.ino | 68 +++++++++++++-----------
 1 file changed, 37 insertions(+), 31 deletions(-)

diff --git a/examples/CAN_Read_Demo/CAN_Read_Demo.ino b/examples/CAN_Read_Demo/CAN_Read_Demo.ino
index 38b82a1..3ef54c1 100644
--- a/examples/CAN_Read_Demo/CAN_Read_Demo.ino
+++ b/examples/CAN_Read_Demo/CAN_Read_Demo.ino
@@ -14,45 +14,51 @@ Distributed as-is; no warranty is given.
 #include <mcp2515.h>
 #include <mcp2515_defs.h>
 
-//********************************Setup Loop*********************************//
+tCAN message;
 
 void setup() {
   Serial.begin(9600); // For debug use
-  Serial.println("CAN Read - Testing receival of CAN Bus message");  
+  Serial.println("CAN Read - Testing receival of CAN Bus message");
+
   delay(1000);
-  
-  if(Canbus.init(CANSPEED_500))  //Initialise MCP2515 CAN controller at the specified speed
+
+  if (Canbus.init(CANSPEED_500)) {
     Serial.println("CAN Init ok");
-  else
+  } else {
     Serial.println("Can't init CAN");
-    
+  }
+
   delay(1000);
 }
 
-//********************************Main Loop*********************************//
-
-void loop(){
-
-  tCAN message;
-if (mcp2515_check_message()) 
-	{
-    if (mcp2515_get_message(&message)) 
-	{
-        //if(message.id == 0x620 and message.data[2] == 0xFF)  //uncomment when you want to filter
-             //{
-               
-               Serial.print("ID: ");
-               Serial.print(message.id,HEX);
-               Serial.print(", ");
-               Serial.print("Data: ");
-               Serial.print(message.header.length,DEC);
-               for(int i=0;i<message.header.length;i++) 
-                {	
-                  Serial.print(message.data[i],HEX);
-                  Serial.print(" ");
-                }
-               Serial.println("");
-             //}
-           }}
+void loop() {
+
+  if (!mcp2515_check_message()) {
+    return;
+  }
+
+  memset(&message, 0, sizeof(message))
+
+  if (!mcp2515_get_message(&message)) {
+    return;
+  }
+
+  /* uncomment when you want to filter
+  if(message.id == 0x620 and message.data[2] != 0xFF) { 
+    return;
+  }
+  */
+
+  Serial.print("ID: ");
+  Serial.print(message.id,HEX);
+  Serial.print(", ");
+  Serial.print("Data: ");
+  Serial.print(message.header.length,DEC);
+
+  for(int i = 0; i < message.header.length; i++) {
+    Serial.print(message.data[i], HEX);
+    Serial.print(" ");
+  }
 
+  Serial.println();
 }