safety length check

mikalhart · mikalhart · commit 6f5ccbb6ac0d · 2024-11-06T09:38:29.000-06:00
diff --git a/src/SparkFun_LG290P_GNSS.cpp b/src/SparkFun_LG290P_GNSS.cpp
@@ -1002,7 +1002,7 @@ void LG290P::nmeaHandler(SEMP_PARSE_STATE *parse)
 {
     // Is this a command response?
     std::string sentence = (const char *)parse->buffer;
-    if (sentence.substr(sentence.length() - 2) == "\r\n")
+    if (sentence.length() >= 2 && sentence.substr(sentence.length() - 2) == "\r\n")
         // if (sentence.ends_with("\r\n"))
         sentence.erase(sentence.size() - 2);
 

Original file line number	Diff line number	Diff line change
`@@ -1002,7 +1002,7 @@ void LG290P::nmeaHandler(SEMP_PARSE_STATE *parse)`
`1002`	`1002`	`{`
`1003`	`1003`	`// Is this a command response?`
`1004`	`1004`	`std::string sentence = (const char *)parse->buffer;`
`1005`		`- if (sentence.substr(sentence.length() - 2) == "\r\n")`
	`1005`	`+ if (sentence.length() >= 2 && sentence.substr(sentence.length() - 2) == "\r\n")`
`1006`	`1006`	`// if (sentence.ends_with("\r\n"))`
`1007`	`1007`	`sentence.erase(sentence.size() - 2);`
`1008`	`1008`