Prevent memory leak in pointperfectTryZtpToken. Also:

Correct debugPpCertificate print
Do secureClient.stop in pointperfectUpdateKeys

Author: PaulZC

Firmware/RTK_Everywhere/menuPP.ino

@@ -555,6 +555,8 @@ ZtpResponse pointperfectTryZtpToken(String &ztpRequest)
                         strncpy(tempHolderPtr, (const char *)((*jsonZtp)["privateKey"]), MQTT_CERT_SIZE - 1);
                         recordFile("privateKey", tempHolderPtr, strlen(tempHolderPtr));
 
+                        free(tempHolderPtr); // Clean up. Done with tempHolderPtr
+
                         // Validate the keys
                         if (!checkCertificates())
                         {
@@ -732,7 +734,10 @@ bool checkCertificates()
         free(keyContents);
 
     if (settings.debugPpCertificate)
-        systemPrintln("Stored certificates are valid!");
+    {
+        systemPrintf("Stored certificates are %svalid\r\n", validCertificates ? "" : "NOT ");
+    }
+
     return (validCertificates);
 }
 
@@ -816,6 +821,7 @@ bool pointperfectUpdateKeys()
     do
     {
         // Allocate the buffers
+        // Freed outside the do loop
         if (online.psram == true)
         {
             certificateContents = (char *)ps_malloc(MQTT_CERT_SIZE);
@@ -829,8 +835,6 @@ bool pointperfectUpdateKeys()
 
         if ((!certificateContents) || (!keyContents))
         {
-            if (certificateContents)
-                free(certificateContents);
             systemPrintln("Failed to allocate content buffers!");
             break;
         }
@@ -858,6 +862,8 @@ bool pointperfectUpdateKeys()
         // Configure the MQTT client
         menuppMqttClient->setId(settings.pointPerfectClientID);
         menuppMqttClient->onMessage(mqttCallback);
+        menuppMqttClient->setKeepAliveInterval(10 * 1000);
+        menuppMqttClient->setConnectionTimeout( 5 * 1000);
 
         // Attempt to the MQTT broker
         systemPrintf("Attempting to connect to MQTT broker: %s\r\n", settings.pointPerfectBrokerHost);
@@ -933,6 +939,8 @@ bool pointperfectUpdateKeys()
         menuppMqttClient = nullptr;
     }
 
+    secureClient.stop();
+
     // Free the content buffers
     if (keyContents)
         free(keyContents);