imporove error handling of dig

Author: freekmurze

src/Exceptions/CouldNotFetchDns.php

@@ -12,11 +12,15 @@ public static function noHandlerFound(): self
         return new static('A runnable handler could not be found');
     }
 
-    public static function digReturnedWithError(Process $process): self
+    public static function digReturnedWithError(Process $process, string $command): self
     {
         $output = trim($process->getErrorOutput());
 
-        return new static("Dig command failed with message: `{$output}`");
+        if (empty($output)) {
+            $output = trim($process->getOutput());
+        }
+
+        return new static("Dig command `{$command}` failed with message: `{$output}`");
     }
 
     public static function dnsGetRecordReturnedWithError(string $error): self

src/Handlers/Dig.php

@@ -10,14 +10,18 @@ class Dig extends Handler
 {
     public function __invoke(string $domain, int $flag, string $type): array
     {
+        $command = $this->buildCommand($domain, $type);
+
         $process = new Process($this->buildCommand($domain, $type));
 
         $process
             ->enableOutput()
             ->run();
 
         if (! $process->isSuccessful()) {
-            throw CouldNotFetchDns::digReturnedWithError($process);
+            $command = implode(' ', $command);
+
+            throw CouldNotFetchDns::digReturnedWithError($process, $command);
         }
 
         return $this->transform(

tests/DnsTest.php

@@ -145,7 +145,6 @@ public function it_uses_default_nameserver_if_not_set()
     public function it_throws_exception_on_failed_to_fetch_dns_record()
     {
         $this->expectException(CouldNotFetchDns::class);
-        $this->expectExceptionMessage("Dig command failed with message: `dig: couldn't get address for 'dns.spatie.be': not found`");
 
         $this->dns
             ->useNameserver('dns.spatie.be')