From a4b7bf79f518907b0b7300b13f7cb19a4d11cdaa Mon Sep 17 00:00:00 2001 From: erikn69 Date: Thu, 31 Oct 2024 11:56:50 -0500 Subject: [PATCH 1/3] PHP 8.4 tests --- src/OptimizerChain.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/OptimizerChain.php b/src/OptimizerChain.php index db603e3..3c4e310 100644 --- a/src/OptimizerChain.php +++ b/src/OptimizerChain.php @@ -62,7 +62,7 @@ public function useLogger(LoggerInterface $log) return $this; } - public function optimize(string $pathToImage, string $pathToOutput = null) + public function optimize(string $pathToImage, ?string $pathToOutput = null) { if ($pathToOutput) { $check = copy($pathToImage, $pathToOutput); From 48c4b988930577e7fbedeb7d49021cbb57788ea5 Mon Sep 17 00:00:00 2001 From: erikn69 Date: Thu, 31 Oct 2024 11:58:06 -0500 Subject: [PATCH 2/3] PHP 8.4 tests --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a201cec..f54dd3e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -9,7 +9,7 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest] - php: [8.3, 8.2, 8.1, 8.0, 7.4, 7.3] + php: [8.4, 8.3, 8.2, 8.1, 8.0, 7.4, 7.3] dependency-version: [prefer-lowest, prefer-stable] name: P${{ matrix.php }} - ${{ matrix.dependency-version }} - ${{ matrix.os }} From b11bf8d412424a884c5ac33fa947ddb8d1f50b30 Mon Sep 17 00:00:00 2001 From: erikn69 Date: Thu, 31 Oct 2024 16:58:22 +0000 Subject: [PATCH 3/3] Fix styling --- src/OptimizerChain.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/OptimizerChain.php b/src/OptimizerChain.php index 3c4e310..c95b09f 100644 --- a/src/OptimizerChain.php +++ b/src/OptimizerChain.php @@ -66,7 +66,7 @@ public function optimize(string $pathToImage, ?string $pathToOutput = null) { if ($pathToOutput) { $check = copy($pathToImage, $pathToOutput); - if($check == false) { + if ($check == false) { throw new InvalidArgumentException("Cannot copy file"); } $pathToImage = $pathToOutput;