Skip to content

Commit 97da598

Browse files
xinydevtomzawadzki
authored andcommitted
make: Fix build error on Arm
- disable the buildvcs feature to avoid an "obtaining VCS status error" on Arm (golang/go#51253) - binaries will be stamped with vesion control information if buildvcs=true is set. If you specify buildvcs=true and version control information is available but cannot be included due to a missing tool or an ambiguous directory structure, go build will raise an error Signed-off-by: Xin Yang <[email protected]> Change-Id: I979e2c78c3446b44d92d6b6eeb9ac9441b010704 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk-csi/+/15537 Tested-by: SPDK CI Jenkins <[email protected]> Reviewed-by: Tomasz Zawadzki <[email protected]> Reviewed-by: Jim Harris <[email protected]> Reviewed-by: Yibo Cai <[email protected]> Reviewed-by: Antti Kervinen <[email protected]>
1 parent 4f5b466 commit 97da598

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ all: spdkcsi lint test
4242
.PHONY: spdkcsi
4343
spdkcsi:
4444
@echo === building spdkcsi binary
45-
@CGO_ENABLED=0 GOARCH=$(GOARCH) GOOS=linux go build -o $(OUT_DIR)/spdkcsi ./cmd/
45+
@CGO_ENABLED=0 GOARCH=$(GOARCH) GOOS=linux go build -buildvcs=false -o $(OUT_DIR)/spdkcsi ./cmd/
4646

4747
# static code check, text lint
4848
lint: golangci yamllint shellcheck

0 commit comments

Comments
 (0)