valid_csr test: move mock clock initialisation before any operations #5942
Conversation
sorindumitru
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
Otherwise by the time we run the test the seconds of the clock might have rolled and cause us to think that the CA is valid for 1 hour - 1 second instead of 1 hour. Signed-off-by: Sorin Dumitru <[email protected]>
There was a problem hiding this comment.
Thank you @sorindumitru for looking at this.
I don't think that clock.Mock advances the time unless that the Add method is called? In that case, I don't think that this change would have any effect.
The problem is that the CA is created at the start of the function, because it's needed for some test expectations. It may be valid from 13:25:51.000 to 14:25:51.000, for example. This will also cap (or at least that's what it seemed it did) the lifetime of the issued intermediate CAs. The mock clock gets initialized for each subtest, using the current time. If the test takes longer than a second, the mock clock will have the now() as 14:25:52.000 as opposed to (14:25:51). During the test we verify that that the difference between the I was able to consistently reproduce this issue using |
There was a problem hiding this comment.
Thank you for the detailed explanation, @sorindumitru. That makes sense!
Otherwise by the time we run the test the seconds of the clock might have rolled and cause us to think that the CA is valid for 1 hour - 1 second instead of 1 hour.
Affected functionality
tests
Description of change
move mock clock initialisation before any operations, otherwise by the time we run the test the seconds of the clock might have rolled and cause us to think that the CA is valid for 1 hour - 1 second instead of 1 hour.
Which issue this PR fixes
fixes #5841