Skip to content

Commit 3b9a8b7

Browse files
committed
chore: cleaning
1 parent 7f10180 commit 3b9a8b7

File tree

4 files changed

+10
-14
lines changed

4 files changed

+10
-14
lines changed

release_notes/unreleased.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
**Unreleased**
22

33
* Migrated app to Splunk SOAR SDK
4-
* Updated to support Python 3.13/3.14
5-
* Modernized app structure and dependencies
4+
* Updated to support Python 3.13
5+
* Modernized app, structure, and dependencies

src/app.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,7 +531,6 @@ class GetEmailParams(Params):
531531

532532
class GetEmailOutput(ActionOutput):
533533
# Make all fields optional since not all emails have all headers
534-
# Using Pydantic Field with default=None for optional fields
535534
message: str | None = None
536535
container_id: int | None = None
537536
ARC_Authentication_Results: str | None = PydanticField(

src/process_email.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,23 +29,20 @@
2929
from bs4 import BeautifulSoup, UnicodeDammit
3030
from requests.structures import CaseInsensitiveDict
3131

32-
try:
33-
import phantom.app as phantom
34-
except ImportError:
35-
from soar_sdk.shims import phantom
36-
from soar_sdk.shims.phantom.app import APP_SUCCESS, APP_ERROR
32+
from soar_sdk.shims import phantom
33+
from soar_sdk.shims.phantom.app import APP_SUCCESS, APP_ERROR
3734

38-
phantom.APP_SUCCESS = APP_SUCCESS
39-
phantom.APP_ERROR = APP_ERROR
40-
phantom.is_fail = lambda x: x == APP_ERROR
41-
phantom.is_success = lambda x: x == APP_SUCCESS
35+
phantom.APP_SUCCESS = APP_SUCCESS
36+
phantom.APP_ERROR = APP_ERROR
37+
phantom.is_fail = lambda x: x == APP_ERROR
38+
phantom.is_success = lambda x: x == APP_SUCCESS
4239

4340
from . import phantom_rules
4441
from . import phantom_utils as ph_utils
4542
import contextlib
4643

4744

48-
# Simple URL validator to replace Django URLValidator
45+
# URL validator replacement
4946
class URLValidator:
5047
"""Simple URL validator"""
5148

src/request_handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
)
2727

2828

29-
# Simple HttpResponse replacement
29+
# HttpResponse replacement
3030
class HttpResponse:
3131
"""Simple HTTP response"""
3232

0 commit comments

Comments
 (0)