feat!: imap sdkified #49
Conversation
grokas-splunk
force-pushed
the
grokas/PAPP-36909-sdkify_imap
branch
4 times, most recently
from
183ce35 to
ae06f51
Compare
grokas-splunk
force-pushed
the
grokas/PAPP-36909-sdkify_imap
branch
4 times, most recently
from
84cfc40 to
e6e92fb
Compare
grokas-splunk
force-pushed
the
grokas/PAPP-36909-sdkify_imap
branch
8 times, most recently
from
ff940f6 to
59d56ee
Compare
grokas-splunk
force-pushed
the
grokas/PAPP-36909-sdkify_imap
branch
from
1a2c738 to
b18ad75
Compare
grokas-splunk
force-pushed
the
grokas/PAPP-36909-sdkify_imap
branch
from
b18ad75 to
3b9a8b7
Compare
grokas-splunk
force-pushed
the
grokas/PAPP-36909-sdkify_imap
branch
from
bb6b27f to
f053287
Compare
There was a problem hiding this comment.
Is there a reason this hoisting of app is needed? Just curious
| helper = ImapHelper(soar, asset) | ||
| helper._connect_to_server() | ||
|
|
||
| state = app.actions_manager.ingestion_state |
There was a problem hiding this comment.
CC @sodle-splunk does this actually work, and/or are we in the process of moving this?
| first_run_max_emails: float = AssetField( | ||
| required=True, | ||
| description="Maximum emails to poll first time for schedule and interval polling", | ||
| default=2000.0, | ||
| ) | ||
| max_emails: float = AssetField( | ||
| required=True, description="Maximum emails to poll", default=100.0 | ||
| ) |
There was a problem hiding this comment.
These can only be whole numbers, right? So why are they floats instead of ints?
| f"Error occurred while deleting state file: {ex!s}" | ||
| ) | ||
|
|
||
| def encrypt_state(self, state, connector=None): |
There was a problem hiding this comment.
SDK now handles state encryption and decryption
| isinstance(asset_id, str) and asset_id.isalnum() and len(asset_id) <= 128 | ||
| ) | ||
|
|
||
| def delete_state(self, connector): |
There was a problem hiding this comment.
This function is going to be incompatible with SOAR in the near future, as state is coming off the filesystem
There was a problem hiding this comment.
I think this script is effectively duplicated across the major email apps. I think we need a ticket to reimplement this functionality inside the SDK, under something like a utils namespace
There was a problem hiding this comment.
It would actually probably be best if it was an optional component of the SDK package, since it seems it will bring with it some other dependencies
2 participants
PAPP-36909