Merge pull request #31 from splunk-soar-connectors/jhou/PAPP-36947

fix: format_vars should not be passed if not specified

Author: splunk-jessica

microsoftsqlserver_connector.py

@@ -337,9 +337,15 @@ def _handle_run_query(self, param):
             self.debug_print("Executing run query")
             if non_query:
                 self._connection._conn.execute_non_query("ROLLBACK TRAN")
-                self._connection._conn.execute_non_query(query, format_vars)
+                if format_vars:
+                    self._connection._conn.execute_non_query(query, format_vars)
+                else:
+                    self._connection._conn.execute_non_query(query)
             else:
-                self._cursor.execute(query, format_vars)
+                if format_vars:
+                    self._cursor.execute(query, format_vars)
+                else:
+                    self._cursor.execute(query)
         except Exception as ex:
             return action_result.set_status(phantom.APP_ERROR, "Error running query", self._get_error_message_from_exception(ex))
 

release_notes/unreleased.md

@@ -1 +1,2 @@
 **Unreleased**
+* PAPP-36947: Resolved issue where pymssql incorrectly interpreted literal percent signs as placeholders by conditionally passing format_vars to execute methods only when parameters are provided