Skip to content

Conversation

@sgoral-splunk
Copy link
Contributor

@sgoral-splunk sgoral-splunk commented Aug 4, 2025

Issue number: ADDON-82402

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Sometimes in alert actions empty "rid" parameter is send and it caused problems because it wasn't set but InvalidKey was returned.

Changes

Handlers for empty string was added.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@sgoral-splunk sgoral-splunk marked this pull request as ready for review August 5, 2025 09:06
@sgoral-splunk sgoral-splunk requested a review from a team as a code owner August 5, 2025 09:06
@kkedziak-splunk kkedziak-splunk enabled auto-merge (squash) September 17, 2025 14:33
@kkedziak-splunk kkedziak-splunk merged commit bb19f54 into develop Sep 17, 2025
13 of 14 checks passed
@kkedziak-splunk kkedziak-splunk deleted the fix/empty_rid branch September 17, 2025 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2025
@srv-rr-github-token
Copy link
Contributor

🎉 This PR is included in version 8.0.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants