Skip to content

Commit 93f8330

Browse files
committed
code reformating and added test case
1 parent d2f1916 commit 93f8330

File tree

3 files changed

+31
-5
lines changed

3 files changed

+31
-5
lines changed

src/main/java/com/splunk/hecclient/EventBatch.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,14 @@ public abstract class EventBatch {
4343
protected List<Event> events = new ArrayList<>();
4444

4545
public abstract String getRestEndpoint();
46-
4746
public abstract String getContentType();
48-
4947
public abstract void add(Event event);
50-
5148
public abstract EventBatch createFromThis();
5249

5350
public final void addExtraFields(final Map<String, String> fields) {
5451
// recalculate the batch length since we inject more meta data to each event
5552
int newLength = 0;
56-
for (final Event event : events) {
53+
for (final Event event: events) {
5754
event.addFields(fields);
5855
newLength += event.length();
5956
}
@@ -139,7 +136,7 @@ public final HttpEntity getHttpEntityTemplate() {
139136
public final String toString() {
140137
StringBuilder builder = new StringBuilder();
141138
builder.append("[");
142-
for (Event e : events) {
139+
for (Event e: events) {
143140
builder.append(e.toString());
144141
builder.append(",");
145142
}

src/test/java/com/splunk/hecclient/IndexerTest.java

+22
Original file line numberDiff line numberDiff line change
@@ -216,4 +216,26 @@ public void sendCompressedBatchWithSuccess() {
216216
Assert.assertEquals(CloseableHttpClientMock.success, poller.getResponse());
217217
}
218218
}
219+
220+
@Test
221+
public void sendCompressedRawBatchWithSuccess() {
222+
for (int i = 0; i < 2; i++) {
223+
CloseableHttpClientMock client = new CloseableHttpClientMock();
224+
if (i == 0) {
225+
client.setResponse(CloseableHttpClientMock.success);
226+
}
227+
PollerMock poller = new PollerMock();
228+
229+
Indexer indexer = new Indexer(baseUrl, token, client, poller);
230+
EventBatch batch = UnitUtil.createRawEventBatch();
231+
batch.setEnableCompression(true);
232+
boolean result = indexer.send(batch);
233+
Assert.assertTrue(result);
234+
Assert.assertNotNull(poller.getBatch());
235+
Assert.assertNull(poller.getFailedBatch());
236+
Assert.assertNull(poller.getException());
237+
Assert.assertEquals(indexer.getChannel(), poller.getChannel());
238+
Assert.assertEquals(CloseableHttpClientMock.success, poller.getResponse());
239+
}
240+
}
219241
}

src/test/java/com/splunk/hecclient/UnitUtil.java

+7
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,13 @@ public static EventBatch createBatch() {
3434
return batch;
3535
}
3636

37+
public static EventBatch createRawEventBatch() {
38+
Event event = new RawEvent("ni", "hao");
39+
EventBatch batch = RawEventBatch.factory().build();
40+
batch.add(event);
41+
return batch;
42+
}
43+
3744
public static void milliSleep(long milliseconds) {
3845
try {
3946
TimeUnit.MILLISECONDS.sleep(milliseconds);

0 commit comments

Comments
 (0)