Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change karp-backend version that is used #14

Closed
kod-kristoff opened this issue Sep 26, 2019 · 3 comments · Fixed by #37
Closed

Change karp-backend version that is used #14

kod-kristoff opened this issue Sep 26, 2019 · 3 comments · Fixed by #37

Comments

@kod-kristoff
Copy link
Member

kod-kristoff commented Sep 26, 2019 •
edited
Loading

Currently uses karp-backend v4.
Switch to karp-backend v5?
@danr
Copy link
Contributor

danr commented Sep 26, 2019

Relevanta rader:

fsvreader/app/views.py

Line 19 in 28f0521

app.config['KARP'] = 'https://ws.spraakbanken.gu.se/ws/karp/v4/'

Här hanteras resultatet:

fsvreader/app/views.py

Line 131 in 28f0521

for hit in res.get('hits', {}).get('hits', []):

@kod-kristoff
Copy link
Member Author

Probably not needed, only needed to redirect all users to the correct URL:
https://spraakbanken.gu.se/fsvreader

@kod-kristoff
Copy link
Member Author

Needed since karp-backend-v4 is retired.
Need to rewrite call karp_request to use new karp-backend-v7 backend

@kod-kristoff kod-kristoff linked a pull request Feb 18, 2025 that will close this issue
change karp backend version #37
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change karp backend version spraakbanken/fsvreader
2 participants
@danr @kod-kristoff