Rename FakeChangeset to make it more obviously tied to Unshelve.

Author: spraints

GitTfs.VsCommon/TfsHelper.Common.cs

@@ -223,7 +223,7 @@ public ITfsChangeset GetShelvesetData(IGitTfsRemote remote, string shelvesetOwne
             var wrapperForVersionControlServer =
                 _bridge.Wrap<WrapperForVersionControlServer, VersionControlServer>(VersionControl);
             // TODO - containerify this (no `new`)!
-            var fakeChangeset = new FakeChangeset(shelveset, change, wrapperForVersionControlServer, _bridge);
+            var fakeChangeset = new Unshelveable(shelveset, change, wrapperForVersionControlServer, _bridge);
             var tfsChangeset = new TfsChangeset(remote.Tfs, fakeChangeset, _stdout, null) { Summary = new TfsChangesetInfo { Remote = remote } };
             return tfsChangeset;
         }
@@ -298,21 +298,21 @@ private void WriteShelvesetsToStdoutDetailed(IEnumerable<Shelveset> shelvesets)
 
         #region Fake classes for unshelve
 
-        private class FakeChangeset : IChangeset
+        private class Unshelveable : IChangeset
         {
             private readonly Shelveset _shelveset;
             private readonly PendingSet _pendingSet;
             private readonly IVersionControlServer _versionControlServer;
             private readonly TfsApiBridge _bridge;
             private readonly IChange[] _changes;
 
-            public FakeChangeset(Shelveset shelveset, PendingSet pendingSet, IVersionControlServer versionControlServer, TfsApiBridge bridge)
+            public Unshelveable(Shelveset shelveset, PendingSet pendingSet, IVersionControlServer versionControlServer, TfsApiBridge bridge)
             {
                 _shelveset = shelveset;
                 _versionControlServer = versionControlServer;
                 _bridge = bridge;
                 _pendingSet = pendingSet;
-                _changes = _pendingSet.PendingChanges.Select(x => new FakeChange(x, _bridge, versionControlServer)).Cast<IChange>().ToArray();
+                _changes = _pendingSet.PendingChanges.Select(x => new UnshelveChange(x, _bridge, versionControlServer)).Cast<IChange>().ToArray();
             }
 
             public IChange[] Changes
@@ -349,23 +349,23 @@ public void Get(IWorkspace workspace)
             {
                 foreach (var change in _changes)
                 {
-                    var item = (FakeItem)change.Item;
+                    var item = (UnshelveItem)change.Item;
                     item.Get(workspace);
                 }
             }
         }
 
-        private class FakeChange : IChange
+        private class UnshelveChange : IChange
         {
             private readonly PendingChange _pendingChange;
             private readonly TfsApiBridge _bridge;
-            private readonly FakeItem _fakeItem;
+            private readonly UnshelveItem _fakeItem;
 
-            public FakeChange(PendingChange pendingChange, TfsApiBridge bridge, IVersionControlServer versionControlServer)
+            public UnshelveChange(PendingChange pendingChange, TfsApiBridge bridge, IVersionControlServer versionControlServer)
             {
                 _pendingChange = pendingChange;
                 _bridge = bridge;
-                _fakeItem = new FakeItem(_pendingChange, _bridge, versionControlServer);
+                _fakeItem = new UnshelveItem(_pendingChange, _bridge, versionControlServer);
             }
 
             public TfsChangeType ChangeType
@@ -379,14 +379,14 @@ public IItem Item
             }
         }
 
-        private class FakeItem : IItem
+        private class UnshelveItem : IItem
         {
             private readonly PendingChange _pendingChange;
             private readonly TfsApiBridge _bridge;
             private readonly IVersionControlServer _versionControlServer;
             private long _contentLength = -1;
 
-            public FakeItem(PendingChange pendingChange, TfsApiBridge bridge, IVersionControlServer versionControlServer)
+            public UnshelveItem(PendingChange pendingChange, TfsApiBridge bridge, IVersionControlServer versionControlServer)
             {
                 _pendingChange = pendingChange;
                 _bridge = bridge;