Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 15712ec

Browse files
committed
Make SCDF and Skipper compilable for boot 3.x
* Replaced SocketUtils with TestSocketUtils ** It was moved to the test package. * Migrated httpclient to httpclient5 ** Removed use of httpclient 4.x dependencies added yesterday * Updated Types in AuditRecord Entity to use JdbcTypeCode * Security Modules need to be compiled with Boot3 and securty 6 * Update SCDF to use deployer 3.0.x * Update SCDF pom files to create Java 17 jars * Exclude javax.annotation from deployer artifacts. * Add jakarta annotation dependencies * Update code from javax to jakarta * Replaced Entity @type with @JavaTypeCode * Update JobParam to batch 5. * Update httpclient package to httpclient5 package
1 parent 2003077 commit 15712ec

File tree

76 files changed

+406
-326
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+406
-326
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@
109109
<artifactId>maven-compiler-plugin</artifactId>
110110
<version>3.11.0</version>
111111
<configuration>
112-
<source>1.8</source>
113-
<target>1.8</target>
112+
<source>17</source>
113+
<target>17</target>
114114
</configuration>
115115
</plugin>
116116
<plugin>

spring-cloud-common-security-config/spring-cloud-common-security-config-web/src/main/java/org/springframework/cloud/common/security/IgnoreAllSecurityConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void init(WebSecurity builder) {
4242

4343
@Override
4444
public void configure(WebSecurity builder) {
45-
builder.ignoring().antMatchers("/**");
45+
builder.ignoring().requestMatchers("/**");
4646
}
4747

4848
}

spring-cloud-common-security-config/spring-cloud-common-security-config-web/src/main/java/org/springframework/cloud/common/security/OAuthSecurityConfiguration.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@
6060
import org.springframework.security.authentication.event.AbstractAuthenticationFailureEvent;
6161
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
6262
import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity;
63-
import org.springframework.security.config.annotation.web.configuration.WebSecurityConfigurerAdapter;
63+
import org.springframework.security.config.annotation.web.configurers.ExceptionHandlingConfigurer;
6464
import org.springframework.security.config.annotation.web.configurers.ExpressionUrlAuthorizationConfigurer;
65+
import org.springframework.security.config.annotation.web.configurers.HttpBasicConfigurer;
6566
import org.springframework.security.oauth2.client.OAuth2AuthorizedClientManager;
6667
import org.springframework.security.oauth2.client.OAuth2AuthorizedClientProvider;
6768
import org.springframework.security.oauth2.client.OAuth2AuthorizedClientProviderBuilder;
@@ -104,8 +105,9 @@
104105
* @author Corneil du Plessis
105106
*/
106107
@Configuration(proxyBeanMethods = false)
107-
@ConditionalOnClass(WebSecurityConfigurerAdapter.class)
108-
@ConditionalOnMissingBean(WebSecurityConfigurerAdapter.class)
108+
// SCDF 3.0 Migration - Need to re add this later with a different class or bean.
109+
// @ConditionalOnClass(WebSecurityConfigurerAdapter.class)
110+
// @ConditionalOnMissingBean(WebSecurityConfigurerAdapter.class)
109111
@ConditionalOnWebApplication(type = ConditionalOnWebApplication.Type.ANY)
110112
@EnableWebSecurity
111113
@Conditional(OnOAuth2SecurityEnabled.class)
@@ -122,7 +124,7 @@
122124
OAuthSecurityConfiguration.ProviderManagerConfig.class,
123125
OAuthSecurityConfiguration.AuthenticationProviderConfig.class
124126
})
125-
public class OAuthSecurityConfiguration extends WebSecurityConfigurerAdapter {
127+
public class OAuthSecurityConfiguration {
126128

127129
private static final Logger logger = LoggerFactory.getLogger(OAuthSecurityConfiguration.class);
128130

@@ -199,8 +201,7 @@ public void setSecurityStateBean(SecurityStateBean securityStateBean) {
199201
this.securityStateBean = securityStateBean;
200202
}
201203

202-
@Override
203-
protected void configure(HttpSecurity http) throws Exception {
204+
protected HttpBasicConfigurer configure(HttpSecurity http) throws Exception {
204205

205206
final RequestMatcher textHtmlMatcher = new MediaTypeRequestMatcher(
206207
new BrowserDetectingContentNegotiationStrategy(),
@@ -238,7 +239,7 @@ protected void configure(HttpSecurity http) throws Exception {
238239
security.anyRequest().denyAll();
239240

240241

241-
http.httpBasic().and()
242+
ExceptionHandlingConfigurer configurer = http.httpBasic().and()
242243
.logout()
243244
.logoutSuccessHandler(logoutSuccessHandler)
244245
.and().csrf().disable()
@@ -268,6 +269,7 @@ else if (oAuth2ResourceServerProperties.getJwt().getJwkSetUri() != null) {
268269
}
269270

270271
this.securityStateBean.setAuthenticationEnabled(true);
272+
return http.getConfigurer(HttpBasicConfigurer.class);
271273
}
272274

273275
protected static String dashboard(AuthorizationProperties authorizationProperties, String path) {

spring-cloud-common-security-config/spring-cloud-common-security-config-web/src/main/java/org/springframework/cloud/common/security/support/SecurityConfigUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public static ExpressionUrlAuthorizationConfigurer<HttpSecurity>.ExpressionInter
6969
String attribute = matcher.group(3).trim();
7070

7171
logger.info("Authorization '{}' | '{}' | '{}'", method, attribute, urlPattern);
72-
security = security.antMatchers(method, urlPattern).access(attribute);
72+
security = security.requestMatchers(method, urlPattern).access(attribute);
7373
}
7474
return security;
7575
}

spring-cloud-dataflow-aggregate-task/src/main/java/org/springframework/cloud/dataflow/aggregate/task/AggregateTaskConfiguration.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package org.springframework.cloud.dataflow.aggregate.task;
1717

18-
import javax.annotation.PostConstruct;
1918
import javax.sql.DataSource;
2019

2120
import org.slf4j.Logger;
@@ -91,8 +90,4 @@ public AggregateTaskExplorer aggregateTaskExplorer(
9190
taskDeploymentReader);
9291
}
9392

94-
@PostConstruct
95-
public void setup() {
96-
logger.info("created: org.springframework.cloud.dataflow.aggregate.task.AggregateTaskConfiguration");
97-
}
9893
}

spring-cloud-dataflow-aggregate-task/src/main/java/org/springframework/cloud/dataflow/aggregate/task/impl/DefaultAggregateExecutionSupport.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.springframework.cloud.dataflow.aggregate.task.impl;
1717

18+
import java.time.ZoneId;
1819
import java.util.List;
1920
import java.util.stream.Collectors;
2021

@@ -148,8 +149,8 @@ public AggregateTaskExecution from(TaskExecution execution, String schemaTarget,
148149
execution.getExecutionId(),
149150
execution.getExitCode(),
150151
execution.getTaskName(),
151-
execution.getStartTime(),
152-
execution.getEndTime(),
152+
java.util.Date.from(execution.getStartTime().toInstant(ZoneId.systemDefault().getRules().getOffset(execution.getStartTime()))),
153+
java.util.Date.from(execution.getEndTime().toInstant(ZoneId.systemDefault().getRules().getOffset(execution.getEndTime()))),
153154
execution.getExitMessage(),
154155
execution.getArguments(),
155156
execution.getErrorMessage(),

spring-cloud-dataflow-aggregate-task/src/main/java/org/springframework/cloud/dataflow/aggregate/task/impl/DefaultAggregateTaskExplorer.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package org.springframework.cloud.dataflow.aggregate.task.impl;
1717

18-
import javax.annotation.PostConstruct;
1918
import javax.sql.DataSource;
2019
import java.util.ArrayList;
2120
import java.util.Collection;
@@ -278,8 +277,4 @@ public AggregateTaskExecution getLatestTaskExecutionForTaskName(String taskName)
278277
return aggregateExecutionSupport.from(taskExplorer.getLatestTaskExecutionForTaskName(taskName), target.getName(), getPlatformName(taskName));
279278
}
280279

281-
@PostConstruct
282-
public void setup() {
283-
logger.info("created: org.springframework.cloud.dataflow.aggregate.task.impl.DefaultAggregateTaskExplorer");
284-
}
285280
}

spring-cloud-dataflow-aggregate-task/src/main/java/org/springframework/cloud/dataflow/aggregate/task/impl/DefaultTaskRepositoryContainer.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package org.springframework.cloud.dataflow.aggregate.task.impl;
1818

19-
import javax.annotation.PostConstruct;
2019
import javax.sql.DataSource;
2120
import java.util.HashMap;
2221
import java.util.Map;
@@ -65,8 +64,4 @@ public TaskRepository get(String schemaTarget) {
6564
return repository;
6665
}
6766

68-
@PostConstruct
69-
public void setup() {
70-
logger.info("created: org.springframework.cloud.dataflow.aggregate.task.impl.DefaultTaskRepositoryContainer");
71-
}
7267
}

spring-cloud-dataflow-audit/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
<artifactId>maven-compiler-plugin</artifactId>
4646
<version>3.11.0</version>
4747
<configuration>
48-
<source>1.8</source>
49-
<target>1.8</target>
48+
<source>17</source>
49+
<target>17</target>
5050
</configuration>
5151
</plugin>
5252
<plugin>

spring-cloud-dataflow-build/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
</modules>
1515
<url>https://spring.io/projects/spring-cloud-dataflow</url>
1616
<properties>
17-
<java.version>1.8</java.version>
17+
<java.version>17</java.version>
1818
<resource.delimiter>@</resource.delimiter>
1919
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2020
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

0 commit comments

Comments
 (0)