Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composed Task Graph is not rendered properly when using $END #1653

Closed
cppwfs opened this issue Feb 11, 2021 · 3 comments
Closed

Composed Task Graph is not rendered properly when using $END #1653

cppwfs opened this issue Feb 11, 2021 · 3 comments
Assignees
Labels
for/backport For backporting status/need-triage Team needs to triage and take a first look type/bug Is a bug report

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Feb 11, 2021

The following statement timestamp '*'->t1: timestamp 'FOO'->$END the graph is rendered as
image.png

It should look something like:
image.png
also notice that timestamp is also flagged invalid. But the syntax is parseable by CTR

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Feb 11, 2021
@cppwfs cppwfs added the type/bug Is a bug report label Feb 11, 2021
@cppwfs
Copy link
Contributor Author

cppwfs commented Feb 11, 2021

Refer to issue for additional detail: spring-cloud/spring-cloud-dataflow#4373

@BoykoAlex
Copy link
Collaborator

The problem is on the server side
POST to /tools/parseTaskTextToGraph with body:

{
  dsl: "timestamp '*'->t1: timestamp 'FOO'->$END"
  name: "unknown"
}

The response is:

{
   "graph":{
      "nodes":[
         {
            "id":"0",
            "name":"START"
         },
         {
            "id":"1",
            "name":"timestamp"
         },
         {
            "id":"2",
            "name":"timestamp",
            "metadata":{
               "label":"t1"
            }
         },
         {
            "id":"3",
            "name":"$END"
         },
         {
            "id":"4",
            "name":"END"
         }
      ],
      "links":[
         {
            "from":"0",
            "to":"1"
         },
         {
            "from":"1",
            "to":"2",
            "properties":{
               "transitionName":"*"
            }
         },
         {
            "from":"1",
            "to":"3",
            "properties":{
               "transitionName":"FOO"
            }
         },
         {
            "from":"1",
            "to":"4"
         },
         {
            "from":"2",
            "to":"4"
         }
      ]
   },
   "dsl":null,
   "errors":[
      
   ]
}

@cppwfs
Copy link
Contributor Author

cppwfs commented Feb 19, 2021

This is a fairly old issue. Tracked it back to 2.0. Opened parser issue here: spring-cloud/spring-cloud-dataflow#4399

@cppwfs cppwfs closed this as completed Feb 19, 2021
@jvalkeal jvalkeal removed the branch/3.0.x Issue for a branch label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/backport For backporting status/need-triage Team needs to triage and take a first look type/bug Is a bug report
Projects
None yet
Development

No branches or pull requests

4 participants