Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit 634c22e

Browse files
author
Corneil du Plessis
committed
[CI] Update docker secrets for carvel. [skip ci]
1 parent e76d760 commit 634c22e

File tree

3 files changed

+20
-15
lines changed

3 files changed

+20
-15
lines changed

spring-cloud-dataflow-docs/src/main/asciidoc/configuration-carvel.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ These scripts assume you are connected to a Kubernetes cluster and `kubectl` is
5353

5454
| carvel-import-secret.sh
5555
| <secret-name> <namespace> [secret-namespace] [--import|--placeholder]
56-
| [--plarholder] Creates place holder secret in namespace. [--import] Creates `SecretImport` for secretgen-controller.
56+
| [--placeholder] Creates place holder secret in namespace. [--import] Creates `SecretImport` for secretgen-controller.
5757

5858
| setup-scdf-repo.sh
5959
| [scdf-type] (oss, pro)
@@ -186,7 +186,7 @@ Login to docker and optionally registry.tanzu.vmware.com for Spring Cloud Data F
186186
# When deploying SCDF Pro.
187187
export TANZU_DOCKER_USERNAME="<tanzu-net-username>"
188188
export TANZU_DOCKER_PASSWORD="<tanzu-net-password>"
189-
docker login --username $TANZU_DOCKER_USERNAME --password $TANZU_DOCKER_PASSWORD registry.tanzu.vmware.com
189+
docker login --username $TANZU_DOCKER_USERNAME --password $TANZU_DOCKER_PASSWORD registry.packages.broadcom.com
190190
191191
# Always required to ensure you don't experience rate limiting with Docker HUB
192192
export DOCKER_HUB_USERNAME="<docker-hub-username>"

src/deploy/carvel/carvel-prepare-namespaces.sh

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,15 @@ kubectl create serviceaccount "$SA" --namespace $NS
4242
$SCDIR/carvel-add-registry-secret.sh scdfmetadata docker.io "$DOCKER_HUB_USERNAME" "$DOCKER_HUB_PASSWORD"
4343
$SCDIR/carvel-add-registry-secret.sh reg-creds-dockerhub docker.io "$DOCKER_HUB_USERNAME" "$DOCKER_HUB_PASSWORD"
4444

45+
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dockerhub"},{"name":"scdfmetadata"}]}'
4546

4647
if [ "$SCDF_TYPE" = "pro" ]; then
47-
check_env TANZU_DOCKER_USERNAME
48-
check_env TANZU_DOCKER_PASSWORD
49-
$SCDIR/carvel-add-registry-secret.sh reg-creds-dev-registry dev.registry.tanzu.vmware.com "$TANZU_DOCKER_USERNAME" "$TANZU_DOCKER_PASSWORD"
50-
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dockerhub"},{"name": "reg-creds-dev-registry"}]}'
51-
else
52-
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dockerhub"}]}'
48+
if [ "$TANZU_DOCKER_USERNAME" = "" ]; then
49+
echo "Cannot find TANZU_DOCKER_USERNAME"
50+
else
51+
check_env TANZU_DOCKER_PASSWORD
52+
$SCDIR/carvel-add-registry-secret.sh reg-creds-dev-registry registry.packages.broadcom.com "$TANZU_DOCKER_USERNAME" "$TANZU_DOCKER_PASSWORD"
53+
$SCDIR/carvel-add-registry-secret.sh reg-creds-dev-registry spring-scdf-docker-virtual.usw1.packages.broadcom.com "$TANZU_DOCKER_USERNAME" "$TANZU_DOCKER_PASSWORD"
54+
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dev-registry"}]}'
55+
fi
5356
fi

src/deploy/carvel/prepare-local-namespace.sh

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,15 @@ kubectl create serviceaccount "$SA" --namespace $NS
3838

3939
$SCDIR/add-local-registry-secret.sh scdfmetadata docker.io "$DOCKER_HUB_USERNAME" "$DOCKER_HUB_PASSWORD"
4040
$SCDIR/add-local-registry-secret.sh reg-creds-dockerhub docker.io "$DOCKER_HUB_USERNAME" "$DOCKER_HUB_PASSWORD"
41-
41+
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dockerhub"},{"name":"scdfmetadata"}]}'
4242

4343
if [ "$SCDF_TYPE" = "pro" ]; then
44-
check_env TANZU_DOCKER_USERNAME
45-
check_env TANZU_DOCKER_PASSWORD
46-
$SCDIR/add-local-registry-secret.sh reg-creds-dev-registry dev.registry.tanzu.vmware.com "$TANZU_DOCKER_USERNAME" "$TANZU_DOCKER_PASSWORD"
47-
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dockerhub"},{"name": "reg-creds-dev-registry"}]}'
48-
else
49-
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dockerhub"}]}'
44+
if [ "$TANZU_DOCKER_USERNAME" = "" ]; then
45+
echo "Cannot find TANZU_DOCKER_USERNAME"
46+
else
47+
check_env TANZU_DOCKER_PASSWORD
48+
$SCDIR/carvel-add-registry-secret.sh reg-creds-dev-registry registry.packages.broadcom.com "$TANZU_DOCKER_USERNAME" "$TANZU_DOCKER_PASSWORD"
49+
$SCDIR/carvel-add-registry-secret.sh reg-creds-dev-registry spring-scdf-docker-virtual.usw1.packages.broadcom.com "$TANZU_DOCKER_USERNAME" "$TANZU_DOCKER_PASSWORD"
50+
patch_serviceaccount '{"imagePullSecrets": [{"name": "reg-creds-dev-registry"}]}'
51+
fi
5052
fi

0 commit comments

Comments
 (0)