Support Task Operations and shell commands for task logs #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves spring-cloud#3390 This is to support Acceptance Tests for validating how CTR handles properties
|
Closing PR per request. |
| @@ -105,6 +105,23 @@ | |||
| */ | |||
| TaskExecutionResource taskExecutionStatus(long id); | |||
|
|
|||
| /** | |||
| * Return the task execution log. The platform to from which to retrieve the log will be set to {@code default}. | |||
| return id; | ||
| } | ||
|
|
||
| private void waitForDBToBePopulated(long id) throws Exception { |
There was a problem hiding this comment.
Not sure why do we need this method.
There was a problem hiding this comment.
sorry, I get this now.
| public String getTaskExecutionLog(String taskName) throws Exception{ | ||
| long id = launchTaskExecutionForLog(taskName); | ||
| CommandResult cr = shell.executeCommand("task execution log --id " + id); | ||
| assertTrue(cr.toString().contains("Starting TimestampTaskApplication")); |
There was a problem hiding this comment.
Checking TimestampTaskApplication here may not be correct as this method looks generic.
| @@ -229,6 +230,20 @@ public String stop(@CliOption(key = { "", "ids" }, help = "the task execution id | |||
| return String.format("Request to stop the task execution with id(s): %s has been submitted", ids); | |||
| } | |||
|
|
|||
| @CliCommand(value = LOG, help = "Retrieve task execution log") | |||
| public String retrieveTaskExecutionLog(@CliOption(key = { "", "id" }, help = "the task execution id", mandatory = true) long id, | |||
| @CliOption(key = { "", "platform" }, help = "the platform of the task execution", mandatory = false) String platform) { | |||
There was a problem hiding this comment.
We can remove key "" option for the platform key as we can only have one of the options with the default empty key.
|
LGTM, fixing the above minor comments and merging the PR. |
|
Rebased and merged as d324ebe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3390
This is to support Acceptance Tests for validating how CTR handles properties