Skip to content

Fabric8 leader election (CAN ONLY GO IN THE NEXT MAJOR RELEASE) #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 267 commits into
base: main
Choose a base branch
from

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented May 28, 2024

No description provided.

wind57 added 30 commits March 15, 2023 18:43
wind57 added 26 commits January 19, 2025 16:52
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
@wind57 wind57 marked this pull request as ready for review June 5, 2025 15:27
@wind57
Copy link
Contributor Author

wind57 commented Jun 5, 2025

@ryanjbaxter from the previous conversation that we had some time ago (where you approved the changes), all I did now is add an integration test (that is why I left this PR aside and moved to refactor integration test, so that we can reduce the time, so that I can add this test, for example). I hope this makes sense. it is now ready. thank you

@ryanjbaxter
Copy link
Contributor

But it still needs a major? Also the DCO check needs to pass

@wind57
Copy link
Contributor Author

wind57 commented Jun 5, 2025

  • from the previous conversation, we agreed that since this is feature flag protected (and we do not drop the previous implementation) it does not need a major
  • DCO is is going to be a pain, since I've started this work a lot before we had DCO in place. If you say its a must-have, I will close this one and create a new PR, but it will take a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring Cloud Kubernetes - Use Informers instead of Watchers
4 participants