Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring cloud 2023.0.5 dependency issue. This version bring feign-hc which has an dependency to hc-5.4. #1159

Open
alexisgayte opened this issue Feb 7, 2025 · 3 comments

Comments

@alexisgayte
Copy link

alexisgayte commented Feb 7, 2025

spring cloud 2023.0.5 breaks the contract of bringing only patching versions.

by bringing hc-5.4 it also bring the non fixed issue or breaking change :
orange-guo@66d590c

It also breaks the contract with spring boot 3.3.x which uses 5.3.
https://docs.spring.io/spring-boot/3.3/appendix/dependency-versions/coordinates.html

@alexisgayte alexisgayte changed the title spring cloud 2023.0.5 dependency issue bring feign-hc that bump hc from 5.3 to 5.4 spring cloud 2023.0.5 dependency issue. This version bring feign-hc which has an dependency to hc-5.4. Feb 7, 2025
@spencergibb spencergibb transferred this issue from spring-cloud/spring-cloud-release Feb 7, 2025
@spencergibb
Copy link
Member

See d314ba8

Maybe @OlgaMaciaszek knows

@alexisgayte
Copy link
Author

alexisgayte commented Feb 10, 2025

Seems to have been brought in with 2023.0.4 - and the feign-hc version bump from 13.4 to 13.5.

https://github.com/OpenFeign/feign/blob/13.4/hc5/pom.xml
https://github.com/OpenFeign/feign/blob/13.5/hc5/pom.xml

Thanks @spencergibb for pointing out that is also partly due to openfeign being nasty with you.

And I also wanted to thank you all (@OlgaMaciaszek ) for all the good job you are doing.

@OlgaMaciaszek
Copy link
Collaborator

Thanks for bringing this up, @alexisgayte. We do not manage hc5 version ourselves. It's been brought up by Feign. I will mark this issue for team discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants