Skip to content

Commit 5630664

Browse files
committed
More fixes for README
* Fresh samples code snippets * Some typos
1 parent 88d5c5f commit 5630664

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ GPG_PRIVATE_KEY
2525
The Develocity secret is optional: mostly not used by Maven and Gradle project might not be enrolled for the service.
2626
The `SPRING_RELEASE_CHAT_WEBHOOK_URL` secret is also optional: probably you don't want to notify Google Space about your release, or it is not available for GitHub organization.
2727
As well as `OSSRH_*` secret, since not all releases might go to Maven Central, e.g. private (commercial) repositories only.
28+
Also, the `OSSRH_*` and `CENTRAL_TOKEN_*` secrets are mutually exclusive where `CENTRAL_TOKEN_*` will lead to publishing via [Maven Central Portal](https://central.sonatype.org/register/central-portal/).
2829

2930
The mentioned secrets must be passed explicitly since these reusable workflows might be in different GitHub org than target project.
3031

@@ -49,10 +50,10 @@ They publish artifacts into `libs-snapshot-local` (by default) repository.
4950
The Gradle workflow can be supplied with Develocity secret.
5051

5152
#### Gradle SNAPSHOT caller workflow:
52-
https://github.com/spring-io/spring-github-workflows/blob/29fd75ff06da2789a1fcd9b1732bf8bce4704fa6/samples/ci-snapshot-gradle.yml#L1-L18
53+
https://github.com/spring-io/spring-github-workflows/blob/88d5c5f78e88d00b9ad18885438d4e3657433ccf/samples/ci-snapshot-gradle.yml#L1-L17
5354

5455
#### Maven SNAPSHOT caller workflow:
55-
https://github.com/spring-io/spring-github-workflows/blob/29fd75ff06da2789a1fcd9b1732bf8bce4704fa6/samples/ci-snapshot-maven.yml#L1-L13
56+
https://github.com/spring-io/spring-github-workflows/blob/88d5c5f78e88d00b9ad18885438d4e3657433ccf/samples/ci-snapshot-maven.yml#L1-L14
5657

5758
Both Gradle and Maven SNAPSHOT build workflow requires `ARTIFACTORY_USERNAME` & `ARTIFACTORY_PASSWORD` secretes to authorise [spring-io/artifactory-deploy-action](https://github.com/spring-io/artifactory-deploy-action).
5859
Optionally, all the artifacts can be signed if `GPG_PASSPHRASE` and `GPG_PRIVATE_KEY` secrets are provided.
@@ -85,7 +86,7 @@ Then spring.io project page is updated for newly released version.
8586
And in the end the milestone closed and specific Google Space notified about release (if `SPRING_RELEASE_CHAT_WEBHOOK_URL` secret is present in the repository).
8687

8788
#### Example of Release caller workflow:
88-
https://github.com/spring-io/spring-github-workflows/blob/29fd75ff06da2789a1fcd9b1732bf8bce4704fa6/samples/release-with-gradle.yml#L1-L25
89+
https://github.com/spring-io/spring-github-workflows/blob/88d5c5f78e88d00b9ad18885438d4e3657433ccf/samples/release-with-gradle.yml#L1-L24
8990

9091
Such a workflow must be on every branch which is supposed to be released via GitHub actions.
9192

@@ -152,7 +153,7 @@ The [spring-cherry-pick.yml](.github/workflows/spring-cherry-pick.yml) workflow
152153
For example `Auto-cherry-pick to 6.2.x & 6.1.x`.
153154
The `Auto-cherry-pick` token is a default value for the `autoCherryPickToken` input of this workflow.
154155
The branches to cherry-pick to are extracted from the matching sentence.
155-
The "Auto-cherry-pick" sentence is remove from the target commit message.
156+
The "Auto-cherry-pick" sentence is removed from the target commit message.
156157
The `-x` option of `git cherry-pick` command adds a link back to the original commit.
157158

158159
## Announce Milestone Planning in Chat

0 commit comments

Comments
 (0)