Polish

Author: philwebb

spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java

@@ -477,6 +477,7 @@ public void customize(Connector connector) {
 			}
 
 			factory.addConnectorCustomizers(new TomcatConnectorCustomizer() {
+
 				@Override
 				public void customize(Connector connector) {
 					ProtocolHandler handler = connector.getProtocolHandler();
@@ -489,14 +490,15 @@ public void customize(Connector connector) {
 				}
 
 				private String coerceCompression(String compression) {
-					if (Boolean.toString(true).equals(compression)) {
+					if ("true".equalsIgnoreCase(compression)) {
 						return "on";
 					}
-					else if (Boolean.toString(false).equals(compression)) {
+					if ("false".equalsIgnoreCase(compression)) {
 						return "off";
 					}
 					return compression;
 				}
+
 			});
 
 			if (this.accessLogEnabled) {

spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java

@@ -205,13 +205,13 @@ public void customTomcatCompression() throws Exception {
 	@Test
 	public void disableTomcatCompressionWithYaml() throws Exception {
 		// YAML interprets "off" as false, check that it's mapped back to off
-		assertThat("off", is(equalTo(configureCompression("false"))));
+		assertThat("off", is(equalTo(configureCompression("faLSe"))));
 	}
 
 	@Test
 	public void enableTomcatCompressionWithYaml() throws Exception {
 		// YAML interprets "on" as true, check that it's mapped back to on
-		assertThat("on", is(equalTo(configureCompression("true"))));
+		assertThat("on", is(equalTo(configureCompression("trUE"))));
 	}
 
 	@Test

spring-boot/src/test/java/org/springframework/boot/context/web/ErrorPageFilterTests.java

@@ -325,9 +325,7 @@ public void doFilter(ServletRequest request, ServletResponse response)
 	@Test
 	public void responseIsNotCommitedWhenRequestIsAsync() throws Exception {
 		this.request.setAsyncStarted(true);
-
 		this.filter.doFilter(this.request, this.response, this.chain);
-
 		assertThat(this.chain.getRequest(), equalTo((ServletRequest) this.request));
 		assertThat(((HttpServletResponseWrapper) this.chain.getResponse()).getResponse(),
 				equalTo((ServletResponse) this.response));
@@ -347,9 +345,7 @@ public void doFilter(ServletRequest request, ServletResponse response)
 				throw new RuntimeException("BAD");
 			}
 		};
-
 		this.filter.doFilter(this.request, this.response, this.chain);
-
 		assertThat(this.chain.getRequest(), equalTo((ServletRequest) this.request));
 		assertThat(((HttpServletResponseWrapper) this.chain.getResponse()).getResponse(),
 				equalTo((ServletResponse) this.response));
@@ -368,9 +364,7 @@ public void doFilter(ServletRequest request, ServletResponse response)
 				((HttpServletResponse) response).sendError(400, "BAD");
 			}
 		};
-
 		this.filter.doFilter(this.request, this.response, this.chain);
-
 		assertThat(this.chain.getRequest(), equalTo((ServletRequest) this.request));
 		assertThat(((HttpServletResponseWrapper) this.chain.getResponse()).getResponse(),
 				equalTo((ServletResponse) this.response));
@@ -380,9 +374,7 @@ public void doFilter(ServletRequest request, ServletResponse response)
 	@Test
 	public void responseIsNotCommitedDuringAsyncDispatch() throws Exception {
 		setUpAsyncDispatch();
-
 		this.filter.doFilter(this.request, this.response, this.chain);
-
 		assertThat(this.chain.getRequest(), equalTo((ServletRequest) this.request));
 		assertThat(((HttpServletResponseWrapper) this.chain.getResponse()).getResponse(),
 				equalTo((ServletResponse) this.response));
@@ -402,9 +394,7 @@ public void doFilter(ServletRequest request, ServletResponse response)
 				throw new RuntimeException("BAD");
 			}
 		};
-
 		this.filter.doFilter(this.request, this.response, this.chain);
-
 		assertThat(this.chain.getRequest(), equalTo((ServletRequest) this.request));
 		assertThat(((HttpServletResponseWrapper) this.chain.getResponse()).getResponse(),
 				equalTo((ServletResponse) this.response));
@@ -424,9 +414,7 @@ public void doFilter(ServletRequest request, ServletResponse response)
 				((HttpServletResponse) response).sendError(400, "BAD");
 			}
 		};
-
 		this.filter.doFilter(this.request, this.response, this.chain);
-
 		assertThat(this.chain.getRequest(), equalTo((ServletRequest) this.request));
 		assertThat(((HttpServletResponseWrapper) this.chain.getResponse()).getResponse(),
 				equalTo((ServletResponse) this.response));
@@ -439,9 +427,7 @@ public void responseIsNotFlushedIfStatusIsLessThan400AndItHasAlreadyBeenCommitte
 		HttpServletResponse committedResponse = mock(HttpServletResponse.class);
 		given(committedResponse.isCommitted()).willReturn(true);
 		given(committedResponse.getStatus()).willReturn(200);
-
 		this.filter.doFilter(this.request, committedResponse, this.chain);
-
 		verify(committedResponse, times(0)).flushBuffer();
 	}