Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish public doc for Spring Boot 3 upgrade of a rules_spring service (e.g. OpenRewrite) #43528

Closed
plaird opened this issue Dec 16, 2024 · 1 comment
Labels
for: external-project For an external project and not something we can fix

Comments

@plaird
Copy link

plaird commented Dec 16, 2024

We have 100+ rules_spring.springboot() usages inside a Bazel monorepo internally. We have developed tooling for helping with the Boot2 -> Boot3 upgrade.

There are almost always manual fixes to do after the tooling runs, but it can solve most of the upgrade. We rely on a combination of:

  • Docs with a lot of details
  • OpenRewrite procedure (requires generating a pom.xml using pomgen)
  • Various caveman bash scripts that invoke sed a lot

90% of this is not specific to Salesforce. We should provide this to other victims build teams.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2024
@plaird
Copy link
Author

plaird commented Dec 16, 2024

Sorry, wrong repo!

How embarrassing. For those curious, this was intended for the rules_spring (Bazel specific toolchain) repo. Now here:
salesforce/rules_spring#230

Too many open tabs, sent it to the wrong spot.

@plaird plaird closed this as completed Dec 16, 2024
@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2024
@wilkinsona wilkinsona removed the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2024
@philwebb philwebb added the for: external-project For an external project and not something we can fix label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Development

No branches or pull requests

4 participants