-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Smallrye Mutiny support #2471
Conversation
depends on spring-projects/spring-data-build#1545 |
Thanks a lot for your contribution. For the time being we would like to include only the addition of Mutiny to our registry and adapter infrastructure. Care to remove the repository base interfaces as these aren't required and we do not have native implementations using Mutiny? |
Is there any Repository implementations using RxJava 2/3? I would like to add it firstly, and then add a standalone spring data hibernate module(reactive and blocking). Currently Spring Data JPA does not support reactive APIs, but Hibernate Reative provides JPA like APIs to reactive world, Hibernate Reactive has built-in SmallRye Mutiny support. For those RDBMS developers who are familiar with JPA, migrating to Hibernate Reactive is more reasonable than using R2dbc(not mature as JPA/Jdbc till now). |
For the time being, it can be a local interface in a Spring Data Hibernate Reactive module.
Kind of. With Spring Data 2.x we support RxJava 1 while there is no base RxJava 1 base repository. Generally, Spring Data creates adapters around reactive types so one can use e.g. MongoDB through RxJava 2/3. In the early days, Couchbase was built on RxJava 1 but the repository could be used through |
I see, the ReactiveAdapter can convert between them, for Spring projects, Reactor is enough. |
Do you want to remove both repository base interfaces from the PR or should I take care of this? |
@mp911de I will remove them soon. |
22584bc
to
8d50bce
Compare
@mp911de Updated and rebased on main. |
Add since and author tags. Add ticket references to tests. Reformat code. See #2471
Thank you for your contribution. That's merged and polished now. |
Add since and author tags. Add ticket references to tests. Reformat code. See #2471
aligned to Spring 5.3.10 which added SmallRye Mutiny support, see: spring-projects/spring-framework#27331