Skip to content

Commit 44e7ab6

Browse files
authored
Dependency cleanup and minor updates.
Original Pull Request #1829 Closes #1828
1 parent 67d084b commit 44e7ab6

File tree

5 files changed

+10
-123
lines changed

5 files changed

+10
-123
lines changed

Diff for: pom.xml

+2-19
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
<url>https://github.com/spring-projects/spring-data-elasticsearch</url>
1919

2020
<properties>
21-
<commonslang>2.6</commonslang>
2221
<elasticsearch>7.12.1</elasticsearch>
23-
<log4j>2.13.3</log4j>
24-
<netty>4.1.52.Final</netty>
22+
<log4j>2.14.1</log4j>
23+
<netty>4.1.65.Final</netty>
2524
<springdata.commons>2.6.0-SNAPSHOT</springdata.commons>
2625
<testcontainers>1.15.3</testcontainers>
2726
<blockhound-junit>1.0.6.RELEASE</blockhound-junit>
@@ -132,22 +131,6 @@
132131
<scope>test</scope>
133132
</dependency>
134133

135-
<!-- APACHE -->
136-
<dependency>
137-
<groupId>commons-lang</groupId>
138-
<artifactId>commons-lang</artifactId>
139-
<version>${commonslang}</version>
140-
<scope>test</scope>
141-
</dependency>
142-
143-
<!-- JODA Time -->
144-
<dependency>
145-
<groupId>joda-time</groupId>
146-
<artifactId>joda-time</artifactId>
147-
<version>${jodatime}</version>
148-
<optional>true</optional>
149-
</dependency>
150-
151134
<!-- Elasticsearch -->
152135
<dependency>
153136
<groupId>org.elasticsearch.client</groupId>

Diff for: src/main/java/org/springframework/data/elasticsearch/core/convert/DateTimeConverters.java

-50
This file was deleted.

Diff for: src/test/java/org/springframework/data/elasticsearch/config/ElasticsearchConfigurationSupportUnitTests.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,18 @@
1818
import static org.assertj.core.api.Assertions.*;
1919
import static org.mockito.Mockito.*;
2020

21-
import org.springframework.context.annotation.Bean;
2221
import reactor.core.publisher.Mono;
2322

2423
import java.util.Collection;
2524
import java.util.Collections;
2625

27-
import org.apache.commons.lang.ClassUtils;
2826
import org.elasticsearch.Version;
2927
import org.elasticsearch.action.main.MainResponse;
3028
import org.elasticsearch.client.RestHighLevelClient;
3129
import org.elasticsearch.cluster.ClusterName;
3230
import org.junit.jupiter.api.Test;
3331
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
32+
import org.springframework.context.annotation.Bean;
3433
import org.springframework.context.annotation.Configuration;
3534
import org.springframework.context.support.AbstractApplicationContext;
3635
import org.springframework.data.elasticsearch.annotations.Document;
@@ -52,7 +51,7 @@ public class ElasticsearchConfigurationSupportUnitTests {
5251
public void usesConfigClassPackageAsBaseMappingPackage() throws ClassNotFoundException {
5352

5453
ElasticsearchConfigurationSupport configuration = new StubConfig();
55-
assertThat(configuration.getMappingBasePackages()).contains(ClassUtils.getPackageName(StubConfig.class));
54+
assertThat(configuration.getMappingBasePackages()).contains(StubConfig.class.getPackage().getName());
5655
assertThat(configuration.getInitialEntitySet()).contains(Entity.class);
5756
}
5857

Diff for: src/test/java/org/springframework/data/elasticsearch/core/convert/DateTimeConvertersTests.java

-49
This file was deleted.

Diff for: src/test/java/org/springframework/data/elasticsearch/utils/IndexBuilder.java

+6-2
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,21 @@
22

33
import java.lang.reflect.Field;
44

5-
import org.apache.commons.lang.ArrayUtils;
5+
import org.springframework.core.annotation.AnnotationUtils;
6+
import org.springframework.data.annotation.Id;
67
import org.springframework.data.elasticsearch.core.query.IndexQuery;
78

89
/**
910
* Created by akonczak on 02/12/2015.
11+
*
12+
* @author Peter-Josef Meisch
1013
*/
1114
public class IndexBuilder {
1215

1316
public static IndexQuery buildIndex(Object object) {
1417
for (Field f : object.getClass().getDeclaredFields()) {
15-
if (ArrayUtils.isNotEmpty(f.getAnnotationsByType(org.springframework.data.annotation.Id.class))) {
18+
19+
if (AnnotationUtils.findAnnotation(f, Id.class) != null) {
1620
try {
1721
f.setAccessible(true);
1822
IndexQuery indexQuery = new IndexQuery();

0 commit comments

Comments
 (0)